Fix ordering of installation ID middleware (#17)

bluekeyes · web-flow · commit 9f023162a90f · 2019-07-02T15:55:22.000-07:00
This must come first in the stack so that the value is available to
the metrics middleware added by users.
diff --git a/githubapp/client_creator.go b/githubapp/client_creator.go
@@ -252,7 +252,7 @@ func (c *clientCreator) NewTokenV4Client(token string) (*githubv4.Client, error)
 }
 
 func (c *clientCreator) newClient(base *http.Client, middleware []ClientMiddleware, details string, installID int64) (*github.Client, error) {
-	middleware = append(middleware, setInstallationID(installID))
+	middleware = append([]ClientMiddleware{setInstallationID(installID)}, middleware...)
 	applyMiddleware(base, middleware)
 
 	baseURL, err := url.Parse(c.v3BaseURL)

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ func (c clientCreator) NewTokenV4Client(token string) (githubv4.Client, error)`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`func (c clientCreator) newClient(base http.Client, middleware []ClientMiddleware, details string, installID int64) (*github.Client, error) {`
`255`		`- middleware = append(middleware, setInstallationID(installID))`
	`255`	`+ middleware = append([]ClientMiddleware{setInstallationID(installID)}, middleware...)`
`256`	`256`	`applyMiddleware(base, middleware)`
`257`	`257`
`258`	`258`	`baseURL, err := url.Parse(c.v3BaseURL)`