Skip to content

Commit a3863fe

Browse files
authored
Allow numbers in prefixes (#962)
Allow numbers in prefixes.
1 parent e7727ad commit a3863fe

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
type: improvement
2+
improvement:
3+
description: Allow numbers in prefixes.
4+
links:
5+
- https://github.com/palantir/gradle-git-version/pull/962

readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,12 @@ val gitVersion: groovy.lang.Closure<String> by extra
8585
gitVersion(mapOf("prefix" to "my-product@")) // -> 2.15.0
8686
```
8787

88-
Valid prefixes are defined by the regex `[/@]?([A-Za-z]+[/@-])+`.
88+
Valid prefixes are defined by the regex `[/@]?([A-Za-z0-9]+[/@-])+`.
8989
```
9090
/Abc/
9191
Abc@
9292
foo-bar@
93-
foo/bar@
93+
foo/bar-v2@
9494
```
9595

9696
Tasks

src/main/java/com/palantir/gradle/gitversion/GitVersionArgs.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.util.Map;
2121

2222
class GitVersionArgs {
23-
private static final String PREFIX_REGEX = "[/@]?([A-Za-z]+[/@-])+";
23+
private static final String PREFIX_REGEX = "[/@]?([A-Za-z0-9]+[/@-])+";
2424

2525
private String prefix = "";
2626

src/test/java/com/palantir/gradle/gitversion/GitVersionArgsTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public void allowed_prefixes() throws Exception {
3232
new GitVersionArgs().setPrefix("foo-bar-");
3333
new GitVersionArgs().setPrefix("foo/bar@");
3434
new GitVersionArgs().setPrefix("Foo/Bar@");
35+
new GitVersionArgs().setPrefix("@foo-v3@");
3536
}
3637

3738
@Test

0 commit comments

Comments
 (0)