Excavator: Upgrades Baseline to the latest version (#1322)

Author: svc-excavator-bot

build.gradle

@@ -7,7 +7,7 @@ buildscript {
     dependencies {
         classpath 'com.palantir.jakartapackagealignment:jakarta-package-alignment:0.6.0'
         classpath 'com.gradle.publish:plugin-publish-plugin:1.3.1'
-        classpath 'com.palantir.baseline:gradle-baseline-java:6.35.0'
+        classpath 'com.palantir.baseline:gradle-baseline-java:6.36.0'
         classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:2.34.0'
         classpath 'com.palantir.gradle.externalpublish:gradle-external-publish-plugin:1.19.0'
         classpath 'com.palantir.gradle.failure-reports:gradle-failure-reports:1.14.0'

eclipse_plugin/src/main/java/com/palantir/javaformat/java/PalantirJavaFormatter.java

@@ -60,7 +60,7 @@ public String createIndentationString(int indentationLevel) {
     }
 
     /** Runs the Google Java formatter on the given source, with only the given ranges specified. */
-    @SuppressWarnings({"for-rollout:DefaultLocale", "for-rollout:StatementSwitchToExpressionSwitch"})
+    @SuppressWarnings("for-rollout:StatementSwitchToExpressionSwitch")
     @Nullable
     private TextEdit formatInternal(int kind, String source, IRegion[] regions, int initialIndent) {
         try {

eclipse_plugin/src/main/java/com/palantir/javaformat/java/SnippetFormatter.java

@@ -153,7 +153,7 @@ private static List<Replacement> toReplacements(String source, String replacemen
         return replacements;
     }
 
-    @SuppressWarnings({"for-rollout:StatementSwitchToExpressionSwitch", "for-rollout:UnnecessaryDefaultInEnumSwitch"})
+    @SuppressWarnings("for-rollout:StatementSwitchToExpressionSwitch")
     private SnippetWrapper snippetWrapper(SnippetKind kind, String source, int initialIndent) {
         /*
          * Synthesize a dummy class around the code snippet provided by Eclipse. The

gradle-palantir-java-format/src/main/java/com/palantir/javaformat/gradle/ExecutableTransform.java

@@ -41,7 +41,6 @@
  */
 public abstract class ExecutableTransform implements TransformAction<TransformParameters.None> {
 
-    @SuppressWarnings("for-rollout:NonFinalStaticField")
     private static Logger logger = Logging.getLogger(ExecutableTransform.class);
 
     @InputArtifact

gradle-palantir-java-format/src/main/java/com/palantir/javaformat/gradle/FormatDiff.java

@@ -69,7 +69,6 @@ public static void formatDiff(Path dirToFormat, FormatterService formatter)
     }
 
     /** Parses the filenames and edited ranges out of `git diff -U0`. */
-    @SuppressWarnings("for-rollout:SystemOut")
     @VisibleForTesting
     static Stream<SingleFileDiff> parseGitDiffOutput(String gitOutput) {
         return Streams.stream(Splitter.on(SEPARATOR).omitEmptyStrings().split(gitOutput))
@@ -97,7 +96,6 @@ static Stream<SingleFileDiff> parseGitDiffOutput(String gitOutput) {
                 });
     }
 
-    @SuppressWarnings("for-rollout:SystemOut")
     private static void format(FormatterService formatter, SingleFileDiff diff) {
         String input;
         try {

gradle-palantir-java-format/src/main/java/com/palantir/javaformat/gradle/JavaFormatExtension.java

@@ -51,7 +51,6 @@ private FormatterService serviceLoadInternal() {
                 })
                 .toArray(URL[]::new);
 
-        @SuppressWarnings("for-rollout:BanClassLoader")
         ClassLoader classLoader = new URLClassLoader(jarUris, FormatterService.class.getClassLoader());
         return Iterables.getOnlyElement(ServiceLoader.load(FormatterService.class, classLoader));
     }

gradle-palantir-java-format/src/main/java/com/palantir/javaformat/gradle/SpotlessInterop.java

@@ -29,7 +29,6 @@
  * {@link com.palantir.javaformat.gradle.PalantirJavaFormatSpotlessPlugin} even if spotless is not on the classpath.
  */
 final class SpotlessInterop {
-    @SuppressWarnings("for-rollout:NonFinalStaticField")
     private static Logger logger = Logging.getLogger(SpotlessInterop.class);
 
     private SpotlessInterop() {}

gradle-palantir-java-format/src/main/java/com/palantir/javaformat/gradle/spotless/NativePalantirJavaFormatStep.java

@@ -30,7 +30,6 @@
 import org.gradle.api.logging.Logging;
 
 public final class NativePalantirJavaFormatStep {
-    @SuppressWarnings("for-rollout:NonFinalStaticField")
     private static Logger logger = Logging.getLogger(NativePalantirJavaFormatStep.class);
 
     private NativePalantirJavaFormatStep() {}

idea-plugin/src/main/java/com/palantir/javaformat/intellij/FormatterProvider.java

@@ -100,7 +100,6 @@ private static Optional<FormatterService> createFormatter(FormatterCacheKey cach
         // Use "in-process" formatter service
         log.info("Using in-process formatter for jdk version {}", jdkMajorVersion);
         URL[] implementationUrls = toUrlsUnchecked(implementationClasspath);
-        @SuppressWarnings("for-rollout:BanClassLoader")
         ClassLoader classLoader = new URLClassLoader(implementationUrls, FormatterService.class.getClassLoader());
         return ServiceLoader.load(FormatterService.class, classLoader).findFirst();
     }

palantir-java-format-jdk-bootstrap/src/main/java/com/palantir/javaformat/bootstrap/BootstrappingFormatterService.java

@@ -68,7 +68,6 @@ public String formatSourceReflowStringsAndFixImports(String input) {
         }
     }
 
-    @SuppressWarnings("for-rollout:CheckedExceptionNotThrown")
     @Override
     public String fixImports(String input) throws FormatterException {
         try {