Use zero value by default for comments edited time when simulating PR status (#978)

Author: asvoboda

policy/simulated/options.go

@@ -72,15 +72,15 @@ type Comment struct {
 	Body         string     `json:"body"`
 }
 
-// setDefaults sets the createdAt and lastEdtedAt values to time.Now() if they are otherwise unset
+// setDefaults sets the createdAt value to time.Now(), and the lastEditedAt value to zero, if they are otherwise unset
 func (c *Comment) setDefaults() {
 	now := time.Now()
 	if c.CreatedAt == nil {
 		c.CreatedAt = &now
 	}
 
 	if c.LastEditedAt == nil {
-		c.LastEditedAt = &now
+		c.LastEditedAt = &time.Time{}
 	}
 }
 
@@ -112,7 +112,7 @@ func (r *Review) setDefaults(id, sha string) {
 	}
 
 	if r.LastEditedAt == nil {
-		r.LastEditedAt = &now
+		r.LastEditedAt = &time.Time{}
 	}
 
 	r.ID = id

policy/simulated/options_test.go

@@ -82,11 +82,11 @@ func TestOptionDefaults(t *testing.T) {
 	options.setDefaults()
 	for _, comment := range options.AddComments {
 		assert.False(t, comment.CreatedAt.IsZero())
-		assert.False(t, comment.LastEditedAt.IsZero())
+		assert.True(t, comment.LastEditedAt.IsZero())
 	}
 
 	for _, review := range options.AddReviews {
 		assert.False(t, review.CreatedAt.IsZero())
-		assert.False(t, review.LastEditedAt.IsZero())
+		assert.True(t, review.LastEditedAt.IsZero())
 	}
 }