Skip to content

Augmentation to the simulation API response #955

@ScottLindley

Description

@ScottLindley

Hello! I see in server/handler/simulate.go that the SimulationResponse is a subset of common.Response. Is there any reason to not include all the data within common.Response? Would a PR that augmented SimulationResponse to be a 1:1 DTO mapping of common.Response be welcomed?

// SimulationResponse is the response returned from Simulate, this is a trimmed down version of common.Result with json
// tags. This struct and the newSimulationResponse constructor can be extended to include extra content from common.Result.
type SimulationResponse struct {
Name string `json:"name"`
Description string `json:"description:"`
StatusDescription string `json:"status_description"`
Status string `json:"status"`
Error string `json:"error"`
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions