-
Notifications
You must be signed in to change notification settings - Fork 131
Open
Description
Hello! I see in server/handler/simulate.go that the SimulationResponse is a subset of common.Response. Is there any reason to not include all the data within common.Response? Would a PR that augmented SimulationResponse to be a 1:1 DTO mapping of common.Response be welcomed?
policy-bot/server/handler/simulate.go
Lines 37 to 45 in bbf6336
| // SimulationResponse is the response returned from Simulate, this is a trimmed down version of common.Result with json | |
| // tags. This struct and the newSimulationResponse constructor can be extended to include extra content from common.Result. | |
| type SimulationResponse struct { | |
| Name string `json:"name"` | |
| Description string `json:"description:"` | |
| StatusDescription string `json:"status_description"` | |
| Status string `json:"status"` | |
| Error string `json:"error"` | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels