Skip to content

Commit 3136f6c

Browse files
committed
fix mypy findings
1 parent acf3c85 commit 3136f6c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

tests/test_extension_object.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import pytest
66
import sqlalchemy as sa
77
from flask import Flask
8-
from sqlalchemy.orm import joinedload
98
from werkzeug.exceptions import NotFound
109

1110
from flask_sqlalchemy import SQLAlchemy
@@ -28,11 +27,11 @@ def test_get_or_404_kwargs(app: Flask) -> None:
2827
db = SQLAlchemy(app)
2928

3029
class User(db.Model):
31-
id = sa.Column(db.Integer, primary_key=True)
30+
id = sa.Column(db.Integer, primary_key=True) # type: ignore[var-annotated]
3231

3332
class Todo(db.Model):
3433
id = sa.Column(sa.Integer, primary_key=True)
35-
user_id = sa.Column(sa.ForeignKey(User.id))
34+
user_id = sa.Column(sa.ForeignKey(User.id)) # type: ignore[var-annotated]
3635
user = db.relationship(User)
3736

3837
with app.app_context():
@@ -41,7 +40,7 @@ class Todo(db.Model):
4140
db.session.commit()
4241

4342
with app.app_context():
44-
item = db.get_or_404(Todo, 1, options=[joinedload(Todo.user)])
43+
item = db.get_or_404(Todo, 1, options=[db.joinedload(Todo.user)])
4544
assert item.user.id == 1
4645
# one query with join, no second query when accessing relationship
4746
assert len(get_recorded_queries()) == 1

0 commit comments

Comments
 (0)