fix bugbear liniting issues

Author: jkittner

src/wtforms/widgets/core.py

@@ -79,7 +79,7 @@ def html_params(**kwargs):
         elif v is False:
             pass
         else:
-            params.append(f'{str(k)}="{escape(v)}"')
+            params.append(f'{str(k)}="{escape(v)}"')  # noqa: B907
     return " ".join(params)
 
 

tests/test_csrf.py

@@ -99,8 +99,10 @@ class Meta:
     def test_various_failures(self):
         with pytest.raises(TypeError):
             self.F()
-        with pytest.raises(Exception):
+        with pytest.raises(Exception) as e:
             self.F(meta={"csrf_secret": None})
+        (msg,) = e.value.args
+        assert msg == "must set `csrf_secret` on class Meta for SessionCSRF to work"
 
     def test_no_time_limit(self):
         session = {}

tests/validators/test_anyof.py

@@ -37,4 +37,5 @@ def formatter(values):
     dummy_field.data = 4
     with pytest.raises(ValidationError) as e:
         validator(dummy_form, dummy_field)
-        assert str(e.value) == "test 9::8::7"
+    (msg,) = e.value.args
+    assert msg == "test 9::8::7"

tests/validators/test_data_required.py

@@ -33,9 +33,11 @@ def test_data_required_clobber(dummy_form, dummy_field):
     dummy_field.data = ""
     dummy_field.errors = ["Invalid Integer Value"]
     assert len(dummy_field.errors) == 1
-    with pytest.raises(StopValidation):
+    with pytest.raises(StopValidation) as e:
         validator(dummy_form, dummy_field)
-        assert len(dummy_field.errors) == 0
+    assert len(dummy_field.errors) == 0
+    (msg,) = e.value.args
+    assert msg == "This field is required."
 
 
 @pytest.mark.parametrize(
@@ -53,7 +55,8 @@ def test_data_required_messages(dummy_form, dummy_field, validator, message):
 
     with pytest.raises(StopValidation) as e:
         validator(dummy_form, dummy_field)
-        assert str(e.value) == message
+    (msg,) = e.value.args
+    assert msg == message
 
 
 def test_required_passes(dummy_form, dummy_field):

tests/validators/test_input_required.py

@@ -43,4 +43,5 @@ def test_input_required_error_message(dummy_form, dummy_field, validator, messag
 
     with pytest.raises(StopValidation) as e:
         validator(dummy_form, dummy_field)
-        assert str(e.value) == message
+    (msg,) = e.value.args
+    assert msg == message

tests/validators/test_lazy_proxy.py

@@ -14,8 +14,13 @@ def test_lazy_proxy_raises(really_lazy_proxy):
     """
     Tests that the validators support lazy translation strings for messages.
     """
-    with pytest.raises(Exception):
+    with pytest.raises(Exception) as e:
         str(really_lazy_proxy)
+    (msg,) = e.value.args
+    assert msg == (
+        "Translator function called during form declaration: "
+        "it should be called at response time."
+    )
 
 
 def test_lazy_proxy_fixture(really_lazy_proxy):

tests/validators/test_length.py

@@ -55,4 +55,5 @@ def test_length_messages(dummy_form, dummy_field, validator, message):
 
     with pytest.raises(ValidationError) as e:
         validator(dummy_form, dummy_field)
-        assert str(e.value) == message
+    (msg,) = e.value.args
+    assert message in msg

tests/validators/test_optional.py

@@ -27,11 +27,11 @@ def test_input_optional_raises(data_v, raw_data_v, dummy_form, dummy_field):
 
     with pytest.raises(StopValidation):
         validator(dummy_form, dummy_field)
-        assert validator.field_flags == {"optional": True}
+    assert validator.field_flags == {"optional": True}
 
     dummy_field.errors = ["Invalid Integer Value"]
     assert len(dummy_field.errors) == 1
 
     with pytest.raises(StopValidation):
         validator(dummy_form, dummy_field)
-        assert len(dummy_field.errors) == 0
+    assert len(dummy_field.errors) == 0