`test_edit` fails with BSD sed

[mtelka]

I'm running 8.3.0 tests with Python 3.14.0 and I see this failure:

=================================== FAILURES ===================================
__________________________________ test_edit ___________________________________
tests/test_termui.py:397: in test_edit
    assert reopened_file.read() == "aTest\nbTest"
E   AssertionError: assert 'aTest\nbTest\n' == 'aTest\nbTest'
E
E       aTest
E     - bTest
E     + bTest
E     ?      +
=========================== short test summary info ============================
FAILED tests/test_termui.py::test_edit - AssertionError: assert 'aTest\nbTest\n' == 'aTest\nbTest'

    aTest
  - bTest
  + bTest
  ?      +
============ 1 failed, 1284 passed, 21 skipped, 1 xfailed in 5.26s =============

To reproduce the issue I just downloaded the 8.3.0 sdist from PyPI, unpacked it and then started tox -e py314.

Please note that on this platform the sed is not GNU sed, but BSD sed. When I force to use GNU sed in the test, then all tests pass.

Environment:

• Python version: 3.14.0
• Click version: 8.3.0
• OS: OpenIndiana

[davidism]

Seems like BSD set is adding a newline at the end of its output. Happy to review a PR that strips the newline before the assert.

[mtelka]

@davidism how important is to have the input file without the ending \n? If it is not, then maybe we should just add newline there (and also to the assert). What do you think?

[davidism]

That's fine the point was that the content of the edit don't matter, it's the showed of the response to the edit that's being tested.

[mtelka]

Then #3129 should fix the problem.