Skip to content

Commit 315ebc1

Browse files
authored
better type checking during deprecation (#5700)
2 parents c7c8dc3 + 7d5d187 commit 315ebc1

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

src/flask/__init__.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,20 @@
4242
from .wrappers import Request as Request
4343
from .wrappers import Response as Response
4444

45+
if not t.TYPE_CHECKING:
4546

46-
def __getattr__(name: str) -> t.Any:
47-
if name == "__version__":
48-
import importlib.metadata
49-
import warnings
47+
def __getattr__(name: str) -> t.Any:
48+
if name == "__version__":
49+
import importlib.metadata
50+
import warnings
5051

51-
warnings.warn(
52-
"The '__version__' attribute is deprecated and will be removed in"
53-
" Flask 3.2. Use feature detection or"
54-
" 'importlib.metadata.version(\"flask\")' instead.",
55-
DeprecationWarning,
56-
stacklevel=2,
57-
)
58-
return importlib.metadata.version("flask")
52+
warnings.warn(
53+
"The '__version__' attribute is deprecated and will be removed in"
54+
" Flask 3.2. Use feature detection or"
55+
" 'importlib.metadata.version(\"flask\")' instead.",
56+
DeprecationWarning,
57+
stacklevel=2,
58+
)
59+
return importlib.metadata.version("flask")
5960

60-
raise AttributeError(name)
61+
raise AttributeError(name)

0 commit comments

Comments
 (0)