wrappers.py:129: BadRequest flask:2.0.3

[HiroUkiFujii]

Hi,

I fixed flask version from 2.0.0 to 2.0.3 because I encountered the same problem #4341
Then I also fixed ValueError:'name' may not contain a dot '.' character. , according to the url source.

After above fixing, I try to debug below statement.
Does anyone encountered same problem or has a solution?

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/local/lib/python3.8/site-packages/werkzeug/test.py:1134: in get
    return self.open(*args, **kw)
/usr/local/lib/python3.8/site-packages/flask/testing.py:235: in open
    return super().open(
/usr/local/lib/python3.8/site-packages/werkzeug/test.py:1088: in open
    response = self.run_wsgi_app(request.environ, buffered=buffered)
/usr/local/lib/python3.8/site-packages/werkzeug/test.py:955: in run_wsgi_app
    rv = run_wsgi_app(self.application, environ, buffered=buffered)
/usr/local/lib/python3.8/site-packages/werkzeug/test.py:1236: in run_wsgi_app
    app_rv = app(environ, start_response)
/usr/local/lib/python3.8/site-packages/flask/app.py:2091: in __call__
    return self.wsgi_app(environ, start_response)
/usr/local/lib/python3.8/site-packages/flask/app.py:2076: in wsgi_app
    response = self.handle_exception(e)
/usr/local/lib/python3.8/site-packages/flask_cors/extension.py:161: in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
/usr/local/lib/python3.8/site-packages/flask/app.py:2073: in wsgi_app
    response = self.full_dispatch_request()
/usr/local/lib/python3.8/site-packages/flask/app.py:1518: in full_dispatch_request
    rv = self.handle_user_exception(e)
/usr/local/lib/python3.8/site-packages/flask_cors/extension.py:161: in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
/usr/local/lib/python3.8/site-packages/flask/app.py:1386: in handle_user_exception
    return self.handle_http_exception(e)
/usr/local/lib/python3.8/site-packages/flask/app.py:1326: in handle_http_exception
    return self.ensure_sync(handler)(e)
app/views/error_handler.py:18: in custom_client_error_handler
    current_app.logger.warning(exception, extra=dict(extra_data=to_extra_data()))
app/views/error_handler.py:46: in to_extra_data
    json_body=request.json,
/usr/local/lib/python3.8/site-packages/werkzeug/wrappers/request.py:540: in json
    return self.get_json()
/usr/local/lib/python3.8/site-packages/werkzeug/wrappers/request.py:571: in get_json
    return self.on_json_loading_failed(None)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <Request 'http://localhost/api/v1/xxxxx' [GET]>   e = None

    def on_json_loading_failed(self, e: Exception) -> "te.NoReturn":
        if current_app and current_app.debug:
>           raise BadRequest(f"Failed to decode JSON object: {e}")
E           werkzeug.exceptions.BadRequest: 400 Bad Request: Failed to decode JSON object: None

best regards.

[davidism]

app/views/error_handler.py:18: in custom_client_error_handler
    current_app.logger.warning(exception, extra=dict(extra_data=to_extra_data()))
app/views/error_handler.py:46: in to_extra_data
    json_body=request.json,
/usr/local/lib/python3.8/site-packages/werkzeug/wrappers/request.py:540: in json
    return self.get_json()

Looks like you have a custom_client_error_handler method that calls to_extra_data for logging. That calls request.json unconditionally.

In pallets/werkzeug#2355, accessing json now raises a 400 error instead of returning None if the request is not well formed. You can use silent=True to make it return None instead, or you can use request.is_json instead to check if the request has a JSON content type before trying to decode the data.

So you could change line app/views/error_handler.py:46 in your code to json_body=request.get_json(silent=True) if to optionally collect JSON data.

[HiroUkiFujii]

davidism san.

According to your solution, I fixed to json_body=request.get_json(silent=True). Now All tests turn to green!
Thank you for everything.