Rendering templates documentation edit #5484

jaketanis · 2024-05-19T00:42:22Z

jaketanis
May 19, 2024

I am working through the quickstart guide and testing out templates, and this code snippet confused me a bit:

from flask import render_template

@app.route('/hello/')
@app.route('/hello/<name>')
def hello(name=None):
    return render_template('hello.html', name=name)

I wasn't sure why name=name was necessary. I learned that the first name is referring to the variable in the referenced html file:

<!doctype html>
<title>Hello from Flask</title>
{% if name %}
  <h1>Hello {{ name }}!</h1>
{% else %}
  <h1>Hello, World!</h1>
{% endif %}

This may be trivial, but since it confused me, I thought it might of confused others. I wanted to suggest something like this:

@app.route("/hello/")
@app.route('/hello/<name>')
def hello(name=None):
    return render_template('hello.html', person=name)

with the html file looking like this:

<!doctype html>
<title>Hello from Flask</title>
{% if person %}
  <h1>Hello {{ person }}!</h1>
{% else %}
  <h1>Hello, World!</h1>
{% endif %}

I think this helps differentiate the variable in the html file from the url variable. Let me know your thoughts. 😄

davidism · 2024-05-19T01:41:35Z

davidism
May 19, 2024
Maintainer

Makes sense to me, did you want to make a PR?

1 reply

jaketanis May 19, 2024
Author

Makes sense to me, did you want to make a PR?

Yes, just wanted to bring it up here first because the contribution guidelines said to. I'll go ahead and do that!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pallets

Rendering templates documentation edit #5484

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Pallets

Rendering templates documentation edit #5484

Uh oh!

jaketanis May 19, 2024

Replies: 1 comment · 1 reply

Uh oh!

davidism May 19, 2024 Maintainer

Uh oh!

jaketanis May 19, 2024 Author

jaketanis
May 19, 2024

Replies: 1 comment 1 reply

davidism
May 19, 2024
Maintainer

jaketanis May 19, 2024
Author