Add type annotation for FILTERS dict#2148
Closed
r266-tech wants to merge 1 commit intopallets:mainfrom
Closed
Conversation
Fixes #2120 The FILTERS dict was missing a type annotation, causing Pylance to report partially unknown types for Environment.filters. This adds the annotation using the existing F TypeVar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2120
Problem
The
FILTERSdict insrc/jinja2/filters.pywas missing a type annotation, causing Pylance to report partially unknown types forEnvironment.filters.Solution
Added the type annotation
dict[str, F]using the existingFTypeVar defined at line 44 of the same file.Change