Skip to content

Commit c51afed

Browse files
committed
Ask less questions
1 parent 86bd5eb commit c51afed

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

.github/workflows/evaluate.yaml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ jobs:
140140
enable-cache: true
141141
version: "0.4.20"
142142
cache-dependency-glob: "requirements**.txt"
143-
python-version: "3.12"
143+
python-version: "3.11"
144144

145145
- name: Setup node
146146
uses: actions/setup-node@v4
@@ -200,7 +200,14 @@ jobs:
200200
201201
- name: Evaluate local RAG flow
202202
run: |
203-
python evals/evaluate.py --targeturl=http://127.0.0.1:50505/chat --resultsdir=evals/results/pr${{ github.event.issue.number }}
203+
python evals/evaluate.py --targeturl=http://127.0.0.1:50505/chat --resultsdir=evals/results/pr${{ github.event.issue.number }} --numquestions=2
204+
205+
- name: Upload eval results as build artifact
206+
if: ${{ success() }}
207+
uses: actions/upload-artifact@v4
208+
with:
209+
name: eval_result
210+
path: ./evals/results/pr${{ github.event.issue.number }}
204211

205212
- name: Upload server logs as build artifact
206213
uses: actions/upload-artifact@v4
@@ -214,12 +221,6 @@ jobs:
214221
name: server_error_logs
215222
path: ./app/backend/serverlogs.err
216223

217-
- name: Upload eval results as build artifact
218-
uses: actions/upload-artifact@v4
219-
with:
220-
name: eval_result
221-
path: ./evals/results/pr${{ github.event.issue.number }}
222-
223224
- name: Summarize results
224225
if: ${{ success() }}
225226
run: |

app/backend/app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -450,8 +450,8 @@ async def setup_clients():
450450
KB_FIELDS_CONTENT = os.getenv("KB_FIELDS_CONTENT", "content")
451451
KB_FIELDS_SOURCEPAGE = os.getenv("KB_FIELDS_SOURCEPAGE", "sourcepage")
452452

453-
AZURE_SEARCH_QUERY_LANGUAGE = os.getenv("AZURE_SEARCH_QUERY_LANGUAGE", "en-us")
454-
AZURE_SEARCH_QUERY_SPELLER = os.getenv("AZURE_SEARCH_QUERY_SPELLER", "lexicon")
453+
AZURE_SEARCH_QUERY_LANGUAGE = os.getenv("AZURE_SEARCH_QUERY_LANGUAGE") or "en-us"
454+
AZURE_SEARCH_QUERY_SPELLER = os.getenv("AZURE_SEARCH_QUERY_SPELLER") or "lexicon"
455455
AZURE_SEARCH_SEMANTIC_RANKER = os.getenv("AZURE_SEARCH_SEMANTIC_RANKER", "free").lower()
456456

457457
AZURE_SPEECH_SERVICE_ID = os.getenv("AZURE_SPEECH_SERVICE_ID")

app/backend/approaches/approach.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@ async def search(
171171
query_caption="extractive|highlight-false" if use_semantic_captions else None,
172172
vector_queries=search_vectors,
173173
query_type=QueryType.SEMANTIC,
174-
# query_language=self.query_language,
175-
# query_speller=self.query_speller,
174+
query_language=self.query_language,
175+
query_speller=self.query_speller,
176176
semantic_configuration_name="default",
177177
semantic_query=query_text,
178178
)

0 commit comments

Comments
 (0)