Address feedback from Copilot, Gwen, Twitter

Author: pamelafox

.devcontainer/devcontainer.json

@@ -3,7 +3,9 @@
   "image": "mcr.microsoft.com/devcontainers/python:1-3.12-bullseye",
   "features": {
     "ghcr.io/va-h/devcontainers-features/uv:1": {},
-    "ghcr.io/devcontainers/features/node:1": { "version": "lts" }
+    "ghcr.io/devcontainers/features/node:1": { "version": "lts" },
+    "ghcr.io/devcontainers/features/docker-in-docker:2": {},
+    "ghcr.io/azure/azure-dev/azd:latest": {}
   },
   "postCreateCommand": "uv sync",
   "forwardPorts": [6277, 6274],

infra/core/ai/cognitiveservices.bicep

@@ -41,4 +41,3 @@ output id string = account.id
 output name string = account.name
 output location string = account.location
 output skuName string = account.sku.name
-output key string = account.listKeys().key1

infra/core/host/container-app-upsert.bicep

@@ -40,10 +40,7 @@ param containerCpuCoreCount string = '0.5'
 @description('Memory allocated to a single container instance, e.g. 1Gi')
 param containerMemory string = '1.0Gi'
 
-@description('Workload profile name to use for the container app when using private ingress')
-param workloadProfileName string = 'Warm'
-
-resource existingApp 'Microsoft.App/containerApps@2022-03-01' existing = if (exists) {
+resource existingApp 'Microsoft.App/containerApps@2025-01-01' existing = if (exists) {
   name: name
 }
 
@@ -70,8 +67,6 @@ module app 'container-app.bicep' = {
     env: env
     imageName: exists ? existingApp.properties.template.containers[0].image : ''
     targetPort: targetPort
-    // Pass workload profile name parameter
-    workloadProfileName: workloadProfileName
   }
 }
 

infra/core/host/container-app.bicep

@@ -40,9 +40,6 @@ param containerCpuCoreCount string = '0.5'
 @description('Memory allocated to a single container instance, e.g. 1Gi')
 param containerMemory string = '1.0Gi'
 
-@description('Workload profile name to use for the container app when using private ingress')
-param workloadProfileName string = 'Warm'
-
 resource userIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2023-01-31' existing = {
   name: identityName
 }
@@ -111,7 +108,7 @@ resource app 'Microsoft.App/containerApps@2025-01-01' = {
   }
 }
 
-resource containerAppsEnvironment 'Microsoft.App/managedEnvironments@2022-03-01' existing = {
+resource containerAppsEnvironment 'Microsoft.App/managedEnvironments@2025-01-01' existing = {
   name: containerAppsEnvironmentName
 }
 

infra/core/host/container-apps-environment.bicep

@@ -2,62 +2,45 @@ param name string
 param location string = resourceGroup().location
 param tags object = {}
 
-param daprEnabled bool = false
 param logAnalyticsWorkspaceName string = ''
-param applicationInsightsName string = ''
 
 @description('Virtual network name for container apps environment.')
 param vnetName string = ''
 @description('Subnet name for container apps environment integration.')
 param subnetName string = ''
-param subnetResourceId string
+param subnetResourceId string = ''
 
-param usePrivateIngress bool = true
+param usePrivateIngress bool = false
 
-resource containerAppsEnvironment 'Microsoft.App/managedEnvironments@2025-01-01' = {
-  name: name
-  location: location
-  tags: tags
-  properties: {
-    appLogsConfiguration: !empty(logAnalyticsWorkspaceName) ? {
-      destination: 'log-analytics'
-      logAnalyticsConfiguration: {
-        customerId: logAnalyticsWorkspace.properties.customerId
-        sharedKey: logAnalyticsWorkspace.listKeys().primarySharedKey
-      }
-    } : null
-    daprAIInstrumentationKey: daprEnabled && !empty(applicationInsightsName) ? applicationInsights.properties.InstrumentationKey : ''
-    vnetConfiguration: (!empty(vnetName) && !empty(subnetName)) ? {
-      // Use proper subnet resource ID format
-      infrastructureSubnetId: subnetResourceId
-      internal: usePrivateIngress
-    } : null
-    // Configure workload profile for dedicated environment (not consumption)
-    workloadProfiles: usePrivateIngress
-    ? [
-      {
-        name: 'Consumption'
-        workloadProfileType: 'Consumption'
-      }
-      {
-        name: 'Warm'
-        workloadProfileType: 'D4'
-        minimumCount: 1
-        maximumCount: 3
-      }
-    ]
-    : []
-  }
-}
+var useVnet = !empty(vnetName) && !empty(subnetName)
+var useLogging = !empty(logAnalyticsWorkspaceName)
 
-resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2022-10-01' existing = if (!empty(logAnalyticsWorkspaceName)) {
+resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2022-10-01' existing = if (useLogging) {
   name: logAnalyticsWorkspaceName
 }
 
-resource applicationInsights 'Microsoft.Insights/components@2020-02-02' existing = if (daprEnabled && !empty(applicationInsightsName)){
-  name: applicationInsightsName
+module containerAppsEnvironment 'br/public:avm/res/app/managed-environment:0.11.3' = {
+  name: take('${name}-aca-env', 64)
+  params: {
+    name: name
+    location: location
+    tags: tags
+    zoneRedundant: false
+    publicNetworkAccess: 'Enabled'
+    appLogsConfiguration: useLogging ? {
+      destination: 'log-analytics'
+      logAnalyticsConfiguration: {
+        customerId: logAnalyticsWorkspace!.properties.customerId
+        sharedKey: logAnalyticsWorkspace!.listKeys().primarySharedKey
+      }
+    } : {
+      destination: 'azure-monitor'
+    }
+    internal: useVnet ? usePrivateIngress : false
+    infrastructureSubnetResourceId: useVnet ? subnetResourceId : ''
+  }
 }
 
-output defaultDomain string = containerAppsEnvironment.properties.defaultDomain
-output name string = containerAppsEnvironment.name
-output resourceId string = containerAppsEnvironment.id
+output defaultDomain string = containerAppsEnvironment.outputs.defaultDomain
+output name string = containerAppsEnvironment.outputs.name
+output resourceId string = containerAppsEnvironment.outputs.resourceId

infra/core/host/container-apps.bicep

@@ -5,7 +5,6 @@ param tags object = {}
 param containerAppsEnvironmentName string
 param containerRegistryName string
 param logAnalyticsWorkspaceName string = ''
-param applicationInsightsName string = ''
 
 @description('Virtual network name for container apps environment.')
 param vnetName string = ''
@@ -23,7 +22,6 @@ module containerAppsEnvironment 'container-apps-environment.bicep' = {
     location: location
     tags: tags
     logAnalyticsWorkspaceName: logAnalyticsWorkspaceName
-    applicationInsightsName: applicationInsightsName
     vnetName: vnetName
     subnetName: subnetName
     usePrivateIngress: usePrivateIngress