Skip to content

Commit 0a86897

Browse files
committed
fix(comment): #1312 (comment)
1 parent c8e3ab2 commit 0a86897

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

tests/series/arithmetic/bool/test_sub.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from typing import cast
2-
31
import numpy as np
42
from numpy import typing as npt # noqa: F401
53
import pandas as pd
@@ -128,13 +126,13 @@ def test_sub_pd_series() -> None:
128126

129127
# In the following two cases, mypy fails to recognise the second operand as pd.Series[bool]
130128
if TYPE_CHECKING_INVALID_USAGE:
131-
_ = left - cast("pd.Series[bool]", b) # type: ignore[redundant-cast,operator] # pyright: ignore[reportUnnecessaryCast,reportOperatorIssue]
129+
_0 = left - b # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
132130
check(assert_type(left - i, "pd.Series[int]"), pd.Series, np.integer)
133131
check(assert_type(left - f, "pd.Series[float]"), pd.Series, np.floating)
134132
check(assert_type(left - c, "pd.Series[complex]"), pd.Series, np.complexfloating)
135133

136134
if TYPE_CHECKING_INVALID_USAGE:
137-
_ = b - cast("pd.Series[bool]", left) # type: ignore[redundant-cast,operator] # pyright: ignore[reportUnnecessaryCast,reportOperatorIssue]
135+
_1 = b - left # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
138136
check(assert_type(i - left, "pd.Series[int]"), pd.Series, np.integer)
139137
check(assert_type(f - left, "pd.Series[float]"), pd.Series, np.floating)
140138
check(assert_type(c - left, "pd.Series[complex]"), pd.Series, np.complexfloating)

tests/series/arithmetic/bool/test_truediv.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,13 @@ def test_truediv_pd_series() -> None:
179179
c = pd.Series([1.1j, 2.2j, 4.1j])
180180

181181
if TYPE_CHECKING_INVALID_USAGE:
182-
_ = left / b # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
182+
_0 = left / b # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
183183
check(assert_type(left / i, "pd.Series[float]"), pd.Series, np.floating)
184184
check(assert_type(left / f, "pd.Series[float]"), pd.Series, np.floating)
185185
check(assert_type(left / c, "pd.Series[complex]"), pd.Series, np.complexfloating)
186186

187187
if TYPE_CHECKING_INVALID_USAGE:
188-
_ = b / left # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
188+
_1 = b / left # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
189189
check(assert_type(i / left, "pd.Series[float]"), pd.Series, np.floating)
190190
check(assert_type(f / left, "pd.Series[float]"), pd.Series, np.floating)
191191
check(assert_type(c / left, "pd.Series[complex]"), pd.Series, np.complexfloating)

0 commit comments

Comments
 (0)