fix: comments

Author: cmp0xff

pandas-stubs/core/indexes/accessors.pyi

@@ -5,7 +5,6 @@ from datetime import (
     tzinfo as _tzinfo,
 )
 from typing import (
-    Any,
     Generic,
     Literal,
     TypeVar,
@@ -444,7 +443,7 @@ class TimedeltaIndexProperties(
 @type_check_only
 class DtDescriptor:
     @overload
-    def __get__(self, instance: Series[Never], owner: type[Series]) -> Any: ...
+    def __get__(self, instance: Series[Never], owner: type[Series]) -> Properties: ...
     @overload
     def __get__(
         self, instance: Series[Timestamp], owner: type[Series]

pandas-stubs/core/series.pyi

@@ -56,6 +56,7 @@ from pandas.core.api import (
     Int32Dtype as Int32Dtype,
     Int64Dtype as Int64Dtype,
 )
+from pandas.core.arrays.boolean import BooleanDtype
 from pandas.core.arrays.categorical import CategoricalAccessor
 from pandas.core.arrays.datetimes import DatetimeArray
 from pandas.core.arrays.timedeltas import TimedeltaArray
@@ -843,6 +844,10 @@ class Series(IndexOpsMixin[S1], NDFrame):
     @overload
     def diff(self: Series[_bool], periods: int = ...) -> Series: ...
     @overload
+    def diff(
+        self: Series[BooleanDtype], periods: int = ...
+    ) -> Series[BooleanDtype]: ...
+    @overload
     def diff(self: Series[Period], periods: int = ...) -> OffsetSeries: ...
     @overload
     def diff(self: Series[Interval], periods: int = ...) -> Never: ...

tests/scalars/__init__.py

@@ -287,6 +287,16 @@ def test_interval_math() -> None:
         pd.Interval,
     )
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        _i = interval_i - pd.Interval(1, 2)  # type: ignore[type-var] # pyright: ignore[reportOperatorIssue]
+        _f = interval_f - pd.Interval(1.0, 2.0)  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
+        _ts = interval_ts - pd.Interval(  # type: ignore[operator]
+            pd.Timestamp(2025, 9, 29), pd.Timestamp(2025, 9, 30), closed="both"
+        )  # pyright: ignore[reportOperatorIssue]
+        _td = interval_td - pd.Interval(  # type: ignore[operator]
+            pd.Timedelta(1, "ns"), pd.Timedelta(2, "ns")
+        )  # pyright: ignore[reportOperatorIssue]
+
 
 def test_interval_cmp():
     interval_i = pd.Interval(0, 1, closed="left")

tests/test_scalars.py renamed to tests/scalars/test_scalars.py

@@ -1,6 +1,5 @@
 from typing import (
     TYPE_CHECKING,
-    Any,
 )
 
 import numpy as np
@@ -12,6 +11,7 @@
 from pandas.core.indexes.accessors import (
     DatetimeProperties,
     PeriodProperties,
+    Properties,
     TimedeltaProperties,
 )
 from typing_extensions import assert_type
@@ -45,8 +45,9 @@ def test_dt_property() -> None:
 
     if TYPE_CHECKING_INVALID_USAGE:
         s = pd.DataFrame({"a": [1]})["a"]
-        assert_type(s.dt, Any)
-        assert_type(s.dt.year, Any)
+        # python/mypy#19952: mypy believes Properties and its subclasses have a
+        # conflict and gives Any for s.dt
+        assert_type(s.dt, Properties)  # type: ignore[assert-type]
         _1 = pd.Series([1]).dt  # type: ignore[arg-type] # pyright: ignore[reportAttributeAccessIssue]
 
 

tests/series/test_properties.py

@@ -3508,8 +3508,25 @@ def test_diff() -> None:
             pd.Series([True, True, False, False, True]).diff(), "pd.Series[Any]"
         ),
         pd.Series,
-        object,
+        bool,
+        index_to_check_for_type=-1,
     )
+    # nullable bool -> nullable bool
+    with pytest_warns_bounded(
+        UserWarning,
+        r"Instantiating BooleanDtype without any arguments.Pass a BooleanDtype instance to silence this warning.",
+    ):
+        check(
+            assert_type(
+                pd.Series(
+                    [True, True, False, False, True], dtype=pd.BooleanDtype
+                ).diff(),
+                "pd.Series[pd.BooleanDtype]",
+            ),
+            pd.Series,
+            np.bool_,
+            index_to_check_for_type=-1,
+        )
     # Any -> float
     s_o = s.astype(object)
     assert_type(s_o, "pd.Series[Any]")
@@ -3519,22 +3536,20 @@ def test_diff() -> None:
         assert_type(s.astype(complex).diff(), "pd.Series[complex]"), pd.Series, complex
     )
 
-    def _diff_invalid0():  # pyright: ignore[reportUnusedFunction]
-        # interval -> TypeError: IntervalArray has no 'diff' method. Convert to a suitable dtype prior to calling 'diff'.
-        assert_type(pd.Series([pd.Interval(0, 2), pd.Interval(1, 4)]).diff(), Never)
-
-    def _diff_invalid1() -> None:  # pyright: ignore[reportUnusedFunction]
+    if TYPE_CHECKING_INVALID_USAGE:
         # bytes -> numpy.core._exceptions._UFuncNoLoopError: ufunc 'subtract' did not contain a loop with signature matching types (dtype('S21'), dtype('S21')) -> None
         pd.Series([1, 1, 2, 3, 5, 8]).astype(bytes).diff()  # type: ignore[misc] # pyright: ignore[reportAttributeAccessIssue]
 
-    def _diff_invalid2() -> None:  # pyright: ignore[reportUnusedFunction]
         # dtype -> TypeError: unsupported operand type(s) for -: 'type' and 'type'
         pd.Series([str, int, bool]).diff()  # type: ignore[misc] # pyright: ignore[reportAttributeAccessIssue]
 
-    def _diff_invalid3() -> None:  # pyright: ignore[reportUnusedFunction]
         # str -> TypeError: unsupported operand type(s) for -: 'str' and 'str'
         pd.Series(["a", "b"]).diff()  # type: ignore[misc] # pyright: ignore[reportAttributeAccessIssue]
 
+    def _diff_invalid0():  # pyright: ignore[reportUnusedFunction]
+        # interval -> TypeError: IntervalArray has no 'diff' method. Convert to a suitable dtype prior to calling 'diff'.
+        assert_type(pd.Series([pd.Interval(0, 2), pd.Interval(1, 4)]).diff(), Never)
+
 
 def test_operator_constistency() -> None:
     # created for #748