GH1037 Remove na_sentinel from factorize methods

Author: loicdiridollou

pandas-stubs/core/arrays/base.pyi

@@ -42,8 +42,9 @@ class ExtensionArray:
     def shift(self, periods: int = ..., fill_value: object = ...) -> Self: ...
     def unique(self): ...
     def searchsorted(self, value, side: str = ..., sorter=...): ...
-    # TODO: remove keyword-only when pandas removed na_sentinel
-    def factorize(self, *, use_na_sentinel: bool = ...) -> tuple[np.ndarray, Self]: ...
+    def factorize(
+        self, sort: bool = ..., use_na_sentinel: bool = ...
+    ) -> tuple[np.ndarray, Self]: ...
     def repeat(self, repeats, axis=...): ...
     def take(
         self,

tests/test_pandas.py

@@ -790,7 +790,7 @@ def test_lreshape() -> None:
 
 
 def test_factorize() -> None:
-    codes, uniques = pd.factorize(np.array(["b", "b", "a", "c", "b"]))
+    codes, uniques = pd.factorize(np.array(["b", "b", "a", "c", "b"]), sort=False)
     check(assert_type(codes, np.ndarray), np.ndarray)
     check(assert_type(uniques, np.ndarray), np.ndarray)