GH1246 Pr feedback

Author: loicdiridollou

pandas-stubs/core/indexes/base.pyi

@@ -348,10 +348,10 @@ class Index(IndexOpsMixin[S1]):
     def __nonzero__(self) -> None: ...
     __bool__ = ...
     def union(
-        self, other: list[HashableT] | Index, sort: bool | None = ...
+        self, other: list[HashableT] | Self, sort: bool | None = ...
     ) -> Index: ...
     def intersection(self, other: list[S1] | Self, sort: bool | None = ...) -> Self: ...
-    def difference(self, other: list | Index, sort: bool | None = None) -> Self: ...
+    def difference(self, other: list | Self, sort: bool | None = None) -> Self: ...
     def symmetric_difference(
         self,
         other: list[S1] | Self,

pandas-stubs/core/series.pyi

@@ -1739,9 +1739,18 @@ class Series(IndexOpsMixin[S1], NDFrame):
         *args: Any,
         **kwargs: Any,
     ) -> Series[S1]: ...
+    @overload
+    def cumprod(
+        self: Series[_str],
+        axis: AxisIndex = ...,
+        skipna: _bool = ...,
+        *args: Any,
+        **kwargs: Any,
+    ) -> Never: ...
+    @overload
     def cumprod(
         self,
-        axis: AxisIndex | None = ...,
+        axis: AxisIndex = ...,
         skipna: _bool = ...,
         *args: Any,
         **kwargs: Any,
@@ -2219,6 +2228,13 @@ class TimestampSeries(Series[Timestamp]):
         **kwargs: Any,
     ) -> Timedelta: ...
     def diff(self, periods: int = ...) -> TimedeltaSeries: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
+    def cumprod(
+        self,
+        axis: AxisIndex = ...,
+        skipna: _bool = ...,
+        *args: Any,
+        **kwargs: Any,
+    ) -> Never: ...
 
 class TimedeltaSeries(Series[Timedelta]):
     # ignores needed because of mypy
@@ -2326,7 +2342,7 @@ class TimedeltaSeries(Series[Timedelta]):
     ) -> TimedeltaSeries: ...
     def cumprod(
         self,
-        axis: AxisIndex | None = ...,
+        axis: AxisIndex = ...,
         skipna: _bool = ...,
         *args: Any,
         **kwargs: Any,
@@ -2337,6 +2353,13 @@ class PeriodSeries(Series[Period]):
     def dt(self) -> PeriodProperties: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
     def __sub__(self, other: PeriodSeries) -> OffsetSeries: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
     def diff(self, periods: int = ...) -> OffsetSeries: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
+    def cumprod(
+        self,
+        axis: AxisIndex = ...,
+        skipna: _bool = ...,
+        *args: Any,
+        **kwargs: Any,
+    ) -> Never: ...
 
 class OffsetSeries(Series[BaseOffset]):
     @overload  # type: ignore[override]
@@ -2345,6 +2368,13 @@ class OffsetSeries(Series[BaseOffset]):
     def __radd__(  # pyright: ignore[reportIncompatibleMethodOverride]
         self, other: BaseOffset
     ) -> OffsetSeries: ...
+    def cumprod(
+        self,
+        axis: AxisIndex = ...,
+        skipna: _bool = ...,
+        *args: Any,
+        **kwargs: Any,
+    ) -> Never: ...
 
 class IntervalSeries(Series[Interval[_OrderableT]], Generic[_OrderableT]):
     @property

tests/test_indexes.py

@@ -316,18 +316,16 @@ def test_range_index_union():
         ),
         pd.Index,
     )
+
+
+def test_index_union_sort() -> None:
+    """Test sort argument in pd.Index.union GH1264."""
     check(
-        assert_type(
-            pd.RangeIndex(0, 10).union(["a", "b", "c"], sort=True),
-            Union[pd.Index, "pd.Index[int]", pd.RangeIndex],
-        ),
+        assert_type(pd.Index(["e", "f"]).union(["a", "b", "c"], sort=True), pd.Index),
         pd.Index,
     )
     check(
-        assert_type(
-            pd.RangeIndex(0, 10).union(["a", "b", "c"], sort=False),
-            Union[pd.Index, "pd.Index[int]", pd.RangeIndex],
-        ),
+        assert_type(pd.Index(["e", "f"]).union(["a", "b", "c"], sort=False), pd.Index),
         pd.Index,
     )
 

tests/test_series.py

@@ -3943,6 +3943,35 @@ def test_series_index_type() -> None:
         t = pd.Series([1, 2], index="ab")  # type: ignore[call-overload] # pyright: ignore[reportCallIssue, reportArgumentType]
 
 
-def test_timedelta_index_cumsum() -> None:
+def test_timedelta_index_cumprod() -> None:
+    dates = pd.Series(
+        [
+            pd.Timestamp("2020-01-01"),
+            pd.Timestamp("2020-01-15"),
+            pd.Timestamp("2020-02-01"),
+        ],
+        dtype="datetime64[ns]",
+    )
+    as_period_series = pd.Series(pd.PeriodIndex(dates, freq="M"))
+
+    offset_series = as_period_series - as_period_series
+
+    if TYPE_CHECKING_INVALID_USAGE:
+        assert_type(pd.Series(["a", "b"]).cumprod(), Never)
+
+    if TYPE_CHECKING_INVALID_USAGE:
+        assert_type(offset_series.cumprod(), Never)
+
     if TYPE_CHECKING_INVALID_USAGE:
         assert_type(pd.Series([pd.Timedelta(0), pd.Timedelta(1)]).cumprod(), Never)
+
+    if TYPE_CHECKING_INVALID_USAGE:
+        assert_type(
+            pd.Series(
+                [pd.Timestamp("2024-04-29"), pd.Timestamp("2034-08-28")]
+            ).cumprod(),
+            Never,
+        )
+
+    if TYPE_CHECKING_INVALID_USAGE:
+        assert_type(as_period_series.cumprod(), Never)