GH1139 PR Feedback

Author: loicdiridollou

pandas-stubs/core/series.pyi

@@ -1041,9 +1041,9 @@ class Series(IndexOpsMixin[S1], NDFrame):
         broadcast_axis: AxisIndex | None = ...,
     ) -> tuple[Series, Series]: ...
     @overload
-    def rename(  # pyright: ignore[reportOverlappingOverload]
+    def rename(
         self,
-        index: Hashable = ...,
+        index: Hashable,
         *,
         axis: Axis | None = ...,
         copy: bool = ...,
@@ -1052,7 +1052,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
         errors: IgnoreRaise = ...,
     ) -> Self: ...
     @overload
-    def rename(  # type: ignore[overload-cannot-match]
+    def rename(
         self,
         index: Renamer | None = ...,
         *,

tests/test_series.py

@@ -1138,6 +1138,7 @@ def test_types_set_flags() -> None:
 
 def test_types_getitem() -> None:
     s = pd.Series({"key": [0, 1, 2, 3]})
+    check(assert_type(s["key"], Any), list)
     s2 = pd.Series([0, 1, 2, 3])
     check(assert_type(s2[0], int), np.integer)
     check(assert_type(s[:2], pd.Series), pd.Series)
@@ -1227,11 +1228,19 @@ def add1(x: int) -> int:
     s5 = pd.Series([1, 2, 3]).rename({1: 10})
     check(assert_type(s5, "pd.Series[int]"), pd.Series, np.integer)
     # inplace
-    # TODO fix issue with inplace=True returning a Series, cf pandas #60942
     check(
         assert_type(pd.Series([1, 2, 3]).rename("A", inplace=True), "pd.Series[int]"),
         pd.Series,
+        np.integer,
+    )
+    check(
+        assert_type(pd.Series([1, 2, 3]).rename({1: 4, 2: 5}, inplace=True), None),
+        type(None),
     )
+    # TODO this should not raise an error, the lambda is matched with Hashable
+    # check(
+    #     assert_type(pd.Series([1, 2, 3]).rename(lambda x: x**2, inplace=True), None), type(None)
+    # )
 
     if TYPE_CHECKING_INVALID_USAGE:
         s7 = pd.Series([1, 2, 3]).rename({1: [3, 4, 5]})  # type: ignore[arg-type] # pyright: ignore[reportArgumentType]