Skip to content

Commit 34ea623

Browse files
GH1173 PR feedback
1 parent 271cf8d commit 34ea623

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

pandas-stubs/core/frame.pyi

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,14 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
706706
level: int = ...,
707707
target: object | None = ...,
708708
inplace: Literal[True],
709-
**kwargs: Any, # TODO: make more precise https://github.com/pandas-dev/pandas-stubs/issues/1173
709+
) -> None: ...
710+
@overload
711+
def query(
712+
self,
713+
expr: _str,
714+
*,
715+
inplace: Literal[True],
716+
**kwargs: Any,
710717
) -> None: ...
711718
@overload
712719
def query(
@@ -721,7 +728,14 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
721728
resolvers: list[Mapping] | None = ...,
722729
level: int = ...,
723730
target: object | None = ...,
724-
**kwargs: Any, # TODO: make more precise https://github.com/pandas-dev/pandas-stubs/issues/1173
731+
) -> Self: ...
732+
@overload
733+
def query(
734+
self,
735+
expr: _str,
736+
*,
737+
inplace: Literal[False] = ...,
738+
**kwargs: Any,
725739
) -> Self: ...
726740
@overload
727741
def eval(self, expr: _str, *, inplace: Literal[True], **kwargs: Any) -> None: ...

tests/test_frame.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,10 @@ def test_types_query_kwargs() -> None:
529529
pd.DataFrame,
530530
)
531531
kwargs = {"parser": "pandas", "engine": "numexpr"}
532-
check(assert_type(df.query("col1 > col2", inplace=False, **kwargs), pd.DataFrame), pd.DataFrame)
532+
check(
533+
assert_type(df.query("col1 > col2", inplace=False, **kwargs), pd.DataFrame),
534+
pd.DataFrame,
535+
)
533536

534537
check(assert_type(df.query("col1 % col2 == 0", inplace=True), None), type(None))
535538

0 commit comments

Comments
 (0)