Skip to content

Commit 368c3ff

Browse files
committed
refactor: explain a temporary failure
1 parent d333902 commit 368c3ff

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

pandas-stubs/core/series.pyi

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ from pandas.core.dtypes.dtypes import CategoricalDtype
188188
from pandas.plotting import PlotAccessor
189189

190190
_T_COMPLEX = TypeVar("_T_COMPLEX", bound=complex)
191-
_T_TIMESTAMP = TypeVar("_T_TIMESTAMP", bound=Timestamp)
192191

193192
_scalar_timestamp: TypeAlias = date | datetime | np.datetime64
194193
_vector_timestamp: TypeAlias = (
@@ -2052,7 +2051,14 @@ class Series(IndexOpsMixin[S1], NDFrame):
20522051
) -> Series[Timestamp]: ...
20532052
@overload
20542053
def __sub__(
2055-
self: Series[Timestamp], other: _nonseries_timestamp | Series[_T_TIMESTAMP]
2054+
self: Series[Timestamp], other: _nonseries_timestamp
2055+
) -> TimedeltaSeries: ...
2056+
# The following overload confuses mypy and disable it from recognising
2057+
# Series[Any] - Series[Any] should give Series[Any]. It will be fixed
2058+
# after removing TimedeltaSeries.
2059+
@overload
2060+
def __sub__(
2061+
self: Series[Timestamp], other: Series[Timestamp]
20562062
) -> TimedeltaSeries: ...
20572063
@overload
20582064
def __truediv__(

tests/series/test_series.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1606,6 +1606,7 @@ def test_series_min_max_sub_axis() -> None:
16061606
sm = s1 * s2
16071607
sd = s1 / s2
16081608
check(assert_type(sa, pd.Series), pd.Series)
1609+
# Will be fixed after removing TimedeltaSeries, see Series.__sub__ in series.pyi
16091610
check(assert_type(ss, pd.Series), pd.Series) # type: ignore[assert-type]
16101611
check(assert_type(sm, pd.Series), pd.Series)
16111612
check(assert_type(sd, pd.Series), pd.Series)

0 commit comments

Comments
 (0)