Skip to content

Commit 44d0be0

Browse files
committed
fix: comments
1 parent 2c5c14d commit 44d0be0

File tree

2 files changed

+31
-27
lines changed

2 files changed

+31
-27
lines changed

pandas-stubs/core/series.pyi

Lines changed: 27 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2071,10 +2071,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
20712071
@overload
20722072
def __rxor__(self, other: int | np_ndarray_anyint | Series[int]) -> Series[int]: ...
20732073
@overload
2074-
def __sub__(
2075-
self, other: Timestamp | datetime | TimestampSeries
2076-
) -> TimedeltaSeries: ...
2077-
@overload
20782074
def __sub__(self: Series[Never], other: complex | _ListLike | Series) -> Series: ...
20792075
@overload
20802076
def __sub__(self, other: Series[Never]) -> Series: ... # type: ignore[overload-overlap]
@@ -2144,12 +2140,12 @@ class Series(IndexOpsMixin[S1], NDFrame):
21442140
@overload
21452141
def __sub__(
21462142
self: Series[Timestamp],
2147-
other: Timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64,
2143+
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
21482144
) -> TimestampSeries: ...
21492145
@overload
21502146
def __sub__(
21512147
self: Series[Timedelta],
2152-
other: Timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64,
2148+
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
21532149
) -> TimedeltaSeries: ...
21542150
@overload
21552151
def sub(
@@ -2239,6 +2235,22 @@ class Series(IndexOpsMixin[S1], NDFrame):
22392235
axis: int = 0,
22402236
) -> Series[complex]: ...
22412237
@overload
2238+
def sub(
2239+
self: Series[Timestamp],
2240+
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
2241+
level: Level | None = None,
2242+
fill_value: float | None = None,
2243+
axis: int = 0,
2244+
) -> Series[complex]: ...
2245+
@overload
2246+
def sub(
2247+
self: Series[Timedelta],
2248+
other: timedelta | np.timedelta64 | TimedeltaSeries | TimedeltaIndex,
2249+
level: Level | None = None,
2250+
fill_value: float | None = None,
2251+
axis: int = 0,
2252+
) -> Series[complex]: ...
2253+
@overload
22422254
def sub(
22432255
self: Series[_T_COMPLEX],
22442256
other: (
@@ -2329,6 +2341,14 @@ class Series(IndexOpsMixin[S1], NDFrame):
23292341
axis: int = 0,
23302342
) -> Series: ...
23312343
@overload
2344+
def rsub(
2345+
self,
2346+
other: Series[Never],
2347+
level: Level | None = None,
2348+
fill_value: float | None = None,
2349+
axis: int = 0,
2350+
) -> Series: ...
2351+
@overload
23322352
def rsub(
23332353
self: Series[bool],
23342354
other: Just[int] | Sequence[Just[int]] | np_ndarray_anyint | Series[int],
@@ -2507,14 +2527,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
25072527
axis: AxisIndex = 0,
25082528
) -> Series: ...
25092529
@overload
2510-
def truediv(
2511-
self: Series[bool],
2512-
other: np_ndarray_bool,
2513-
level: Level | None = None,
2514-
fill_value: float | None = None,
2515-
axis: AxisIndex = 0,
2516-
) -> Never: ...
2517-
@overload
25182530
def truediv(
25192531
self: Series[bool],
25202532
other: (
@@ -2710,14 +2722,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
27102722
axis: AxisIndex = 0,
27112723
) -> Series: ...
27122724
@overload
2713-
def rtruediv(
2714-
self: Series[bool],
2715-
other: np_ndarray_bool,
2716-
level: Level | None = None,
2717-
fill_value: float | None = None,
2718-
axis: AxisIndex = 0,
2719-
) -> Never: ...
2720-
@overload
27212725
def rtruediv(
27222726
self: Series[bool],
27232727
other: (
@@ -3292,7 +3296,7 @@ class TimestampSeries(_SeriesSubclassBase[Timestamp, np.datetime64]):
32923296
self, other: Timestamp | datetime | TimestampSeries
32933297
) -> TimedeltaSeries: ...
32943298
@overload
3295-
def __sub__(
3299+
def __sub__( # pyright: ignore[reportIncompatibleMethodOverride]
32963300
self,
32973301
other: (
32983302
timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64 | BaseOffset

tests/series/arithmetic/bool/test_truediv.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def test_truediv_numpy_array() -> None:
137137
)
138138

139139
if TYPE_CHECKING_INVALID_USAGE:
140-
assert_type(left.truediv(b), Never)
140+
left.truediv(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
141141
check(assert_type(left.truediv(i), "pd.Series[float]"), pd.Series, np.floating)
142142
check(assert_type(left.truediv(f), "pd.Series[float]"), pd.Series, np.floating)
143143
check(
@@ -147,13 +147,13 @@ def test_truediv_numpy_array() -> None:
147147
)
148148

149149
if TYPE_CHECKING_INVALID_USAGE:
150-
assert_type(left.div(b), Never)
150+
left.div(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
151151
check(assert_type(left.div(i), "pd.Series[float]"), pd.Series, np.floating)
152152
check(assert_type(left.div(f), "pd.Series[float]"), pd.Series, np.floating)
153153
check(assert_type(left.div(c), "pd.Series[complex]"), pd.Series, np.complexfloating)
154154

155155
if TYPE_CHECKING_INVALID_USAGE:
156-
assert_type(left.rtruediv(b), Never)
156+
left.rtruediv(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
157157
check(assert_type(left.rtruediv(i), "pd.Series[float]"), pd.Series, np.floating)
158158
check(assert_type(left.rtruediv(f), "pd.Series[float]"), pd.Series, np.floating)
159159
check(
@@ -163,7 +163,7 @@ def test_truediv_numpy_array() -> None:
163163
)
164164

165165
if TYPE_CHECKING_INVALID_USAGE:
166-
assert_type(left.rdiv(b), Never)
166+
left.rdiv(b) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
167167
check(assert_type(left.rdiv(i), "pd.Series[float]"), pd.Series, np.floating)
168168
check(assert_type(left.rdiv(f), "pd.Series[float]"), pd.Series, np.floating)
169169
check(

0 commit comments

Comments
 (0)