Fix DataFrame.from_records type annotations and add pd.Index test- Change np.ndarray to np_2d_array for data parameter- Change SequenceNotStr[str] to ListLike for columns and exclude parameters- Add test case with pd.Index as columns parameterAddresses review feedback from Dr-Irv

Author: iclectic

pandas-stubs/core/frame.pyi

@@ -546,14 +546,14 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
     def from_records(
         cls,
         data: (
-            np.ndarray
+            np_2d_array
             | Sequence[Any]
             | Iterable[Mapping[str, Any]]
             | Mapping[str, Sequence[Any]]
         ),
         index: str | Sequence[str] | None = None,
-        columns: SequenceNotStr[str] | None = None,
-        exclude: SequenceNotStr[str] | None = None,
+        columns: ListLike | None = None,
+        exclude: ListLike | None = None,
         coerce_float: bool = False,
         nrows: int | None = None,
     ) -> Self: ...

tests/test_frame.py

@@ -4701,6 +4701,15 @@ def test_from_records() -> None:
         pd.DataFrame,
     )
 
+    # testing with pd.Index as columns parameter
+    check(
+        assert_type(
+            pd.DataFrame.from_records(data_tuples, columns=pd.Index(["id", "name"])),
+            pd.DataFrame,
+        ),
+        pd.DataFrame,
+    )
+
     # Testing with numpy structured array
     data_array = np.array(
         [(1, "a"), (2, "b"), (3, "c")],