refactor: return None by ruff

Author: cmp0xff

scripts/_job.py

@@ -14,7 +14,7 @@ class Step:
     rollback: Callable[[], None] | None = None
 
 
-def __rollback_job(steps: deque[Step]):
+def __rollback_job(steps: deque[Step]) -> None:
     """
     Responsible to run rollback of steps.
     """

scripts/test/__init__.py

@@ -25,7 +25,7 @@ def test(
     src: bool = False,
     dist: bool = False,
     type_checker: Literal["", "mypy", "pyright"] = "",
-):
+) -> None:
     steps = []
     if src:
         steps.extend(_SRC_STEPS)

scripts/test/run.py

@@ -5,32 +5,32 @@
 import sys
 
 
-def mypy_src():
+def mypy_src() -> None:
     cmd = ["mypy", "pandas-stubs", "tests", "--no-incremental"]
     subprocess.run(cmd, check=True)
 
 
-def pyright_src():
+def pyright_src() -> None:
     cmd = ["pyright"]
     subprocess.run(cmd, check=True)
 
 
-def pyright_src_strict():
+def pyright_src_strict() -> None:
     cmd = ["pyright", "--project", "pyrightconfig-strict.json"]
     subprocess.run(cmd, check=True)
 
 
-def pytest():
+def pytest() -> None:
     cmd = ["pytest", "--cache-clear"]
     subprocess.run(cmd, check=True)
 
 
-def style():
+def style() -> None:
     cmd = ["pre-commit", "run", "--all-files", "--verbose"]
     subprocess.run(cmd, check=True)
 
 
-def stubtest(allowlist: str = "", check_missing: bool = False):
+def stubtest(allowlist: str = "", check_missing: bool = False) -> None:
     cmd = [
         sys.executable,
         "-m",
@@ -47,47 +47,47 @@ def stubtest(allowlist: str = "", check_missing: bool = False):
     subprocess.run(cmd, check=True)
 
 
-def build_dist():
+def build_dist() -> None:
     cmd = ["poetry", "build", "-f", "wheel"]
     subprocess.run(cmd, check=True)
 
 
-def install_dist():
+def install_dist() -> None:
     path = sorted(Path("dist/").glob("pandas_stubs-*.whl"))[-1]
     cmd = [sys.executable, "-m", "pip", "install", "--force-reinstall", str(path)]
     subprocess.run(cmd, check=True)
 
 
-def rename_src():
+def rename_src() -> None:
     if Path(r"pandas-stubs").exists():
         Path(r"pandas-stubs").rename("_pandas-stubs")
     else:
         raise FileNotFoundError("'pandas-stubs' folder does not exists.")
 
 
-def mypy_dist():
+def mypy_dist() -> None:
     cmd = ["mypy", "tests", "--no-incremental"]
     subprocess.run(cmd, check=True)
 
 
-def pyright_dist():
+def pyright_dist() -> None:
     cmd = ["pyright", "tests"]
     subprocess.run(cmd, check=True)
 
 
-def uninstall_dist():
+def uninstall_dist() -> None:
     cmd = [sys.executable, "-m", "pip", "uninstall", "-y", "pandas-stubs"]
     subprocess.run(cmd, check=True)
 
 
-def restore_src():
+def restore_src() -> None:
     if Path(r"_pandas-stubs").exists():
         Path(r"_pandas-stubs").rename("pandas-stubs")
     else:
         raise FileNotFoundError("'_pandas-stubs' folder does not exists.")
 
 
-def nightly_pandas():
+def nightly_pandas() -> None:
     cmd = [
         sys.executable,
         "-m",
@@ -110,13 +110,13 @@ def _get_version_from_pyproject(program: str) -> str:
     return version_line.split('"')[1]
 
 
-def released_pandas():
+def released_pandas() -> None:
     version = _get_version_from_pyproject("pandas")
     cmd = [sys.executable, "-m", "pip", "install", f"pandas=={version}"]
     subprocess.run(cmd, check=True)
 
 
-def nightly_mypy():
+def nightly_mypy() -> None:
     cmd = [
         sys.executable,
         "-m",
@@ -138,7 +138,7 @@ def nightly_mypy():
     )
 
 
-def released_mypy():
+def released_mypy() -> None:
     version = _get_version_from_pyproject("mypy")
     cmd = [sys.executable, "-m", "pip", "install", f"mypy=={version}"]
     subprocess.run(cmd, check=True)
@@ -152,7 +152,7 @@ def released_mypy():
     )
 
 
-def ty():
+def ty() -> None:
     cmd = [
         "ty",
         "check",
@@ -163,6 +163,6 @@ def ty():
     subprocess.run(cmd, check=True)
 
 
-def pyrefly():
+def pyrefly() -> None:
     cmd = ["pyrefly", "check", "pandas-stubs"]
     subprocess.run(cmd, check=True)

tests/series/test_series.py

@@ -3549,7 +3549,7 @@ def test_diff() -> None:
         # str -> TypeError: unsupported operand type(s) for -: 'str' and 'str'
         pd.Series(["a", "b"]).diff()  # type: ignore[misc] # pyright: ignore[reportAttributeAccessIssue]
 
-    def _diff_invalid0():  # pyright: ignore[reportUnusedFunction]
+    def _diff_invalid0() -> None:  # pyright: ignore[reportUnusedFunction]
         # interval -> TypeError: IntervalArray has no 'diff' method. Convert to a suitable dtype prior to calling 'diff'.
         assert_type(pd.Series([pd.Interval(0, 2), pd.Interval(1, 4)]).diff(), Never)
 

tests/test_api_types.py

@@ -373,7 +373,7 @@ def test_union_categoricals() -> None:
 
 def test_check_extension_dtypes() -> None:
     # GH 315
-    def check_ext_dtype(etype: type[ExtensionDtype]):
+    def check_ext_dtype(etype: type[ExtensionDtype]) -> None:
         assert issubclass(etype, ExtensionDtype)
 
     check_ext_dtype(pd.Int64Dtype)

tests/test_api_typing.py

@@ -46,7 +46,7 @@ def test_dataframegroupby() -> None:
     df = pd.DataFrame({"a": [1, 2, 3]})
     group = df.groupby("a")
 
-    def f1(gb: DataFrameGroupBy):
+    def f1(gb: DataFrameGroupBy) -> None:
         check(gb, DataFrameGroupBy)
 
     f1(group)
@@ -55,7 +55,7 @@ def f1(gb: DataFrameGroupBy):
 def test_seriesgroupby() -> None:
     sr = pd.Series([1, 2, 3], index=pd.Index(["a", "b", "a"]))
 
-    def f1(gb: SeriesGroupBy):
+    def f1(gb: SeriesGroupBy) -> None:
         check(gb, SeriesGroupBy)
 
     f1(sr.groupby(level=0))
@@ -68,7 +68,7 @@ def tests_datetimeindexersamplergroupby() -> None:
     )
     gb_df = df.groupby("col2")
 
-    def f1(gb: ResamplerGroupBy):
+    def f1(gb: ResamplerGroupBy) -> None:
         check(gb, DatetimeIndexResamplerGroupby)
 
     f1(gb_df.resample("ME"))
@@ -81,7 +81,7 @@ def test_timedeltaindexresamplergroupby() -> None:
     )
     gb_df = df.groupby("col2")
 
-    def f1(gb: ResamplerGroupBy):
+    def f1(gb: ResamplerGroupBy) -> None:
         check(gb, TimedeltaIndexResamplerGroupby)
 
     f1(gb_df.resample("1D"))
@@ -92,7 +92,7 @@ def test_periodindexresamplergroupby() -> None:
     idx = pd.period_range("2020-01-28 09:00", periods=4, freq="D")
     df = pd.DataFrame(data=4 * [range(2)], index=idx, columns=["a", "b"])
 
-    def f1(gb: ResamplerGroupBy):
+    def f1(gb: ResamplerGroupBy) -> None:
         check(gb, PeriodIndexResamplerGroupby)
 
     f1(df.groupby("a").resample("3min"))
@@ -113,7 +113,7 @@ def test_nattype() -> None:
 def test_expanding() -> None:
     df = pd.DataFrame({"B": [0, 1, 2, np.nan, 4]})
 
-    def f1(gb: Expanding):
+    def f1(gb: Expanding) -> None:
         check(gb, Expanding)
 
     f1(df.expanding())
@@ -122,7 +122,7 @@ def f1(gb: Expanding):
 def test_expanding_groubpy() -> None:
     df = pd.DataFrame({"B": [0, 1, 2, np.nan, 4]})
 
-    def f1(gb: ExpandingGroupby):
+    def f1(gb: ExpandingGroupby) -> None:
         check(gb, ExpandingGroupby)
 
     f1(df.groupby("B").expanding())
@@ -131,7 +131,7 @@ def f1(gb: ExpandingGroupby):
 def test_ewm() -> None:
     df = pd.DataFrame({"B": [0, 1, 2, np.nan, 4]})
 
-    def f1(gb: ExponentialMovingWindow):
+    def f1(gb: ExponentialMovingWindow) -> None:
         check(gb, ExponentialMovingWindow)
 
     f1(df.ewm(2))
@@ -140,7 +140,7 @@ def f1(gb: ExponentialMovingWindow):
 def test_ewm_groubpy() -> None:
     df = pd.DataFrame({"B": [0, 1, 2, np.nan, 4]})
 
-    def f1(gb: ExponentialMovingWindowGroupby):
+    def f1(gb: ExponentialMovingWindowGroupby) -> None:
         check(gb, ExponentialMovingWindowGroupby)
 
     f1(df.groupby("B").ewm(2))
@@ -149,7 +149,7 @@ def f1(gb: ExponentialMovingWindowGroupby):
 def test_json_reader() -> None:
     df = pd.DataFrame({"B": [0, 1, 2, np.nan, 4]})
 
-    def f1(gb: JsonReader):
+    def f1(gb: JsonReader) -> None:
         check(gb, JsonReader)
 
     with ensure_clean() as path:
@@ -162,7 +162,7 @@ def f1(gb: JsonReader):
 def test_resampler() -> None:
     s = pd.Series([1, 2, 3, 4, 5], index=pd.date_range("20130101", periods=5, freq="s"))
 
-    def f1(gb: Resampler):
+    def f1(gb: Resampler) -> None:
         check(gb, Resampler)
 
     f1(s.resample("3min"))
@@ -171,7 +171,7 @@ def f1(gb: Resampler):
 def test_rolling() -> None:
     df = pd.DataFrame({"B": [0, 1, 2, np.nan, 4]})
 
-    def f1(gb: Rolling):
+    def f1(gb: Rolling) -> None:
         check(gb, Rolling)
 
     f1(df.rolling(2))
@@ -180,7 +180,7 @@ def f1(gb: Rolling):
 def test_rolling_groupby() -> None:
     df = pd.DataFrame({"B": [0, 1, 2, np.nan, 4]})
 
-    def f1(gb: RollingGroupby):
+    def f1(gb: RollingGroupby) -> None:
         check(gb, RollingGroupby)
 
     f1(df.groupby("B").rolling(2))
@@ -189,7 +189,7 @@ def f1(gb: RollingGroupby):
 def test_timegrouper() -> None:
     grouper = pd.Grouper(key="Publish date", freq="1W")
 
-    def f1(gb: TimeGrouper):
+    def f1(gb: TimeGrouper) -> None:
         check(gb, TimeGrouper)
 
     f1(grouper)
@@ -198,7 +198,7 @@ def f1(gb: TimeGrouper):
 def test_window() -> None:
     ser = pd.Series([0, 1, 5, 2, 8])
 
-    def f1(gb: Window):
+    def f1(gb: Window) -> None:
         check(gb, Window)
 
     f1(ser.rolling(2, win_type="gaussian"))
@@ -213,7 +213,7 @@ def test_statereader() -> None:
             path, time_stamp=time_stamp, variable_labels=variable_labels, version=None
         )
 
-        def f1(gb: StataReader):
+        def f1(gb: StataReader) -> None:
             check(gb, StataReader)
 
         with StataReader(path) as reader:

tests/test_plotting.py

@@ -27,12 +27,12 @@
 
 
 @pytest.fixture(autouse=True)
-def autouse_mpl_cleanup(mpl_cleanup):
+def autouse_mpl_cleanup(mpl_cleanup) -> None:
     pass
 
 
 @pytest.fixture
-def close_figures():
+def close_figures() -> None:
     plt.close("all")
 
 

tests/test_styler.py

@@ -40,7 +40,7 @@
 
 
 @pytest.fixture(autouse=True)
-def reset_style():
+def reset_style() -> None:
     DF.style.clear()
 
 
@@ -255,10 +255,4 @@ def color_negative(v: Scalar, /, color: str) -> str | None:
 
     df = DataFrame(np.random.randn(5, 2), columns=["A", "B"])
 
-    check(
-        assert_type(
-            df.style.map(color_negative, color="red"),
-            Styler,
-        ),
-        Styler,
-    )
+    check(assert_type(df.style.map(color_negative, color="red"), Styler), Styler)