GH1327 PR feedback

Author: loicdiridollou

pandas-stubs/core/groupby/groupby.pyi

@@ -74,9 +74,9 @@ from pandas._typing import (
 from pandas.plotting import PlotAccessor
 
 _ResamplerGroupBy: TypeAlias = (
-    DatetimeIndexResamplerGroupby[NDFrameT]
-    | PeriodIndexResamplerGroupby[NDFrameT]
-    | TimedeltaIndexResamplerGroupby[NDFrameT]
+    DatetimeIndexResamplerGroupby[NDFrameT]  # ty: ignore
+    | PeriodIndexResamplerGroupby[NDFrameT]  # ty: ignore
+    | TimedeltaIndexResamplerGroupby[NDFrameT]  # ty: ignore
 )
 
 class GroupBy(BaseGroupBy[NDFrameT]):

pandas-stubs/core/indexes/datetimes.pyi

@@ -104,8 +104,9 @@ class DatetimeIndex(
 
 @overload
 def date_range(
-    end: str | DateAndDatetimeLike,
-    periods: int,
+    *,
+    end: str | DateAndDatetimeLike = ...,
+    periods: int = ...,
     freq: str | timedelta | Timedelta | BaseOffset | None = None,
     tz: TimeZones = None,
     normalize: bool = False,
@@ -116,7 +117,8 @@ def date_range(
 @overload
 def date_range(
     start: str | DateAndDatetimeLike,
-    periods: int,
+    *,
+    periods: int = ...,
     freq: str | timedelta | Timedelta | BaseOffset | None = None,
     tz: TimeZones = None,
     normalize: bool = False,
@@ -126,8 +128,9 @@ def date_range(
 ) -> DatetimeIndex: ...
 @overload
 def date_range(
-    start: str | DateAndDatetimeLike | None,
-    end: str | DateAndDatetimeLike | None,
+    start: str | DateAndDatetimeLike = ...,
+    end: str | DateAndDatetimeLike = ...,
+    *,
     freq: str | timedelta | Timedelta | BaseOffset | None = None,
     tz: TimeZones = None,
     normalize: bool = False,
@@ -137,10 +140,10 @@ def date_range(
 ) -> DatetimeIndex: ...
 @overload
 def date_range(
-    start: str | DateAndDatetimeLike,
-    end: str | DateAndDatetimeLike,
-    periods: int,
-    freq: None = None,
+    start: str | DateAndDatetimeLike = ...,
+    end: str | DateAndDatetimeLike = ...,
+    periods: int = ...,
+    *,
     tz: TimeZones = None,
     normalize: bool = False,
     name: Hashable | None = None,

pandas-stubs/core/indexes/timedeltas.pyi

@@ -81,19 +81,18 @@ class TimedeltaIndex(
 
 @overload
 def timedelta_range(
-    start: TimedeltaConvertibleTypes,
-    end: TimedeltaConvertibleTypes,
-    periods: int,
-    freq: None = None,
+    start: TimedeltaConvertibleTypes = ...,
+    end: TimedeltaConvertibleTypes = ...,
+    periods: int = ...,
+    *,
     name: Hashable | None = None,
     closed: Literal["left", "right"] | None = None,
-    *,
     unit: None | str = ...,
 ) -> TimedeltaIndex: ...
 @overload
 def timedelta_range(
-    start: TimedeltaConvertibleTypes,
-    periods: int,
+    start: TimedeltaConvertibleTypes = ...,
+    periods: int = ...,
     freq: None = None,
     name: Hashable | None = None,
     closed: Literal["left", "right"] | None = None,
@@ -102,31 +101,31 @@ def timedelta_range(
 ) -> TimedeltaIndex: ...
 @overload
 def timedelta_range(
-    start: TimedeltaConvertibleTypes,
-    periods: int,
+    start: TimedeltaConvertibleTypes = ...,
+    *,
+    periods: int = ...,
     freq: str | DateOffset | Timedelta | dt.timedelta | None = None,
     name: Hashable | None = None,
     closed: Literal["left", "right"] | None = None,
-    *,
     unit: None | str = ...,
 ) -> TimedeltaIndex: ...
 @overload
 def timedelta_range(
-    start: TimedeltaConvertibleTypes,
-    end: TimedeltaConvertibleTypes,
+    start: TimedeltaConvertibleTypes = ...,
+    end: TimedeltaConvertibleTypes = ...,
+    *,
     freq: str | DateOffset | Timedelta | dt.timedelta | None = None,
     name: Hashable | None = None,
     closed: Literal["left", "right"] | None = None,
-    *,
     unit: None | str = ...,
 ) -> TimedeltaIndex: ...
 @overload
 def timedelta_range(
+    *,
     end: TimedeltaConvertibleTypes,
     periods: int,
     freq: str | DateOffset | Timedelta | dt.timedelta | None = None,
     name: Hashable | None = None,
     closed: Literal["left", "right"] | None = None,
-    *,
     unit: None | str = ...,
 ) -> TimedeltaIndex: ...

tests/test_styler.py

@@ -143,6 +143,7 @@ def test_highlight_quantile() -> None:
 
 def test_loader() -> None:
     if PD_LTE_23:
+        # see GH62123 for pandas main repo, type changes in pandas 3.0
         check(assert_type(DF.style.loader, PackageLoader), PackageLoader)
 
 

tests/test_timefuncs.py

@@ -1567,7 +1567,7 @@ def test_timedelta_range() -> None:
         day1 = pd.Timedelta(1, unit="D")
         day10 = pd.Timedelta(10, unit="D")
         pd.timedelta_range(
-            day1, day10, periods=10, freq="D"  # type: ignore[call-overload]  # pyright: ignore[reportArgumentType]
+            day1, day10, 10, "D"  # type: ignore[call-overload]  # pyright: ignore[reportArgumentType]
         )
 
 
@@ -1750,6 +1750,13 @@ def test_creating_date_range() -> None:
     dr = pd.date_range(start="2021-12-01", periods=24, freq="h")
     check(assert_type(dr.strftime("%H:%M:%S"), pd.Index), pd.Index, str)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        day1 = pd.Timestamp("2023-04-03")
+        day10 = pd.Timedelta("2023-04-08")
+        pd.date_range(
+            day1, day10, 10, "D"  # type: ignore[call-overload]  # pyright: ignore[reportCallIssue]
+        )
+
 
 def test_timestamp_to_list_add() -> None:
     # https://github.com/microsoft/python-type-stubs/issues/110