fix: comments

Author: cmp0xff

pandas-stubs/core/base.pyi

@@ -5,7 +5,6 @@ from collections.abc import (
 )
 from typing import (
     Any,
-    ClassVar,
     Generic,
     Literal,
     TypeAlias,
@@ -71,7 +70,7 @@ class IndexOpsMixin(OpsMixin, Generic[S1, GenericT_co]):
     def nbytes(self) -> int: ...
     @property
     def size(self) -> int: ...
-    array: ClassVar = ArrayDescriptor()  # noqa
+    array = ArrayDescriptor()
     @overload
     def to_numpy(
         self,

pandas-stubs/core/indexes/accessors.pyi

@@ -443,7 +443,6 @@ class TimedeltaIndexProperties(
 
 @type_check_only
 class DtDescriptor:
-    # microsoft/pyright#10924
     @overload
     def __get__(self, instance: Series[Never], owner: type[Series]) -> Any: ...
     @overload
@@ -456,9 +455,7 @@ class DtDescriptor:
     ) -> TimedeltaProperties: ...
     @overload
     def __get__(
-        self,
-        instance: Series[Period],
-        owner: type[Series],
+        self, instance: Series[Period], owner: type[Series]
     ) -> PeriodProperties: ...
 
 @type_check_only

pandas-stubs/core/series.pyi

@@ -1230,7 +1230,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
         Series[_str],
         Series,
     ]: ...
-    dt: ClassVar = DtDescriptor()  # noqa
+    dt = DtDescriptor()
     @property
     def plot(self) -> PlotAccessor: ...
     sparse = ...

tests/series/test_properties.py

@@ -44,7 +44,9 @@ def test_dt_property() -> None:
     )
 
     if TYPE_CHECKING_INVALID_USAGE:
-        assert_type(pd.DataFrame({"a": [1]})["a"].dt, Any)
+        s = pd.DataFrame({"a": [1]})["a"]
+        assert_type(s.dt, Any)
+        assert_type(s.dt.year, Any)
         _1 = pd.Series([1]).dt  # type: ignore[arg-type] # pyright: ignore[reportAttributeAccessIssue]
 
 
@@ -68,5 +70,6 @@ def test_array_property() -> None:
         pd.Timedelta,
     )
     check(assert_type(pd.Series([1]).array, ExtensionArray), ExtensionArray, np.integer)
-    # mypy gives Any
+    # python/mypy#19952: mypy believes ExtensionArray and its subclasses have a
+    # conflict and gives Any for s.array
     check(assert_type(pd.Series([1, "s"]).array, ExtensionArray), ExtensionArray)  # type: ignore[assert-type]

tests/test_extension.py

@@ -24,6 +24,8 @@ def test_tolist() -> None:
     s = pd.Series(data)
     data1 = [1, 2, 3]
     s1 = pd.Series(data1)
+    # python/mypy#19952: mypy believes ExtensionArray and its subclasses have a
+    # conflict and gives Any for s.array
     check(assert_type(s.array.tolist(), list), list)  # type: ignore[assert-type]
     check(assert_type(s1.array.tolist(), list), list)
     check(assert_type(pd.array([1, 2, 3]).tolist(), list), list)