GH1317 PR feedback

Author: loicdiridollou

pandas-stubs/io/parsers/readers.pyi

@@ -133,7 +133,7 @@ def read_csv(
         | Mapping[str, Sequence[int | str]]
         | None
     ) = None,
-    keep_date_col: bool = ...,
+    keep_date_col: bool = False,
     date_format: dict[Hashable, str] | str | None = None,
     dayfirst: bool = False,
     cache_dates: bool = True,
@@ -196,7 +196,7 @@ def read_csv(
         | Mapping[str, Sequence[int | str]]
         | None
     ) = ...,
-    keep_date_col: bool = ...,
+    keep_date_col: bool = False,
     date_format: dict[Hashable, str] | str | None = ...,
     dayfirst: bool = ...,
     cache_dates: bool = ...,
@@ -250,7 +250,6 @@ def read_table(
     na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = None,
     keep_default_na: bool = True,
     na_filter: bool = True,
-    verbose: bool = ...,
     skip_blank_lines: bool = True,
     parse_dates: (
         bool
@@ -260,8 +259,7 @@ def read_table(
         | Mapping[str, Sequence[int | str]]
         | None
     ) = False,
-    infer_datetime_format: bool = ...,
-    keep_date_col: bool = ...,
+    keep_date_col: bool = False,
     date_format: dict[Hashable, str] | str | None = None,
     dayfirst: bool = False,
     cache_dates: bool = True,
@@ -282,8 +280,7 @@ def read_table(
     on_bad_lines: (
         Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
     ) = "error",
-    delim_whitespace: bool = ...,
-    low_memory: bool = ...,
+    low_memory: bool = True,
     memory_map: bool = False,
     float_precision: Literal["high", "legacy", "round_trip"] | None = None,
     storage_options: StorageOptions | None = None,
@@ -316,7 +313,6 @@ def read_table(
     na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = None,
     keep_default_na: bool = True,
     na_filter: bool = True,
-    verbose: bool = ...,
     skip_blank_lines: bool = True,
     parse_dates: (
         bool
@@ -326,8 +322,7 @@ def read_table(
         | Mapping[str, Sequence[int | str]]
         | None
     ) = False,
-    infer_datetime_format: bool = ...,
-    keep_date_col: bool = ...,
+    keep_date_col: bool = False,
     date_format: dict[Hashable, str] | str | None = None,
     dayfirst: bool = False,
     cache_dates: bool = True,
@@ -348,8 +343,7 @@ def read_table(
     on_bad_lines: (
         Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
     ) = "error",
-    delim_whitespace: bool = ...,
-    low_memory: bool = ...,
+    low_memory: bool = True,
     memory_map: bool = False,
     float_precision: Literal["high", "legacy", "round_trip"] | None = None,
     storage_options: StorageOptions | None = None,
@@ -382,7 +376,6 @@ def read_table(
     na_values: Sequence[str] | Mapping[str, Sequence[str]] | None = None,
     keep_default_na: bool = True,
     na_filter: bool = True,
-    verbose: bool = ...,
     skip_blank_lines: bool = True,
     parse_dates: (
         bool
@@ -392,8 +385,7 @@ def read_table(
         | Mapping[str, Sequence[int | str]]
         | None
     ) = False,
-    infer_datetime_format: bool = ...,
-    keep_date_col: bool = ...,
+    keep_date_col: bool = False,
     date_format: dict[Hashable, str] | str | None = None,
     dayfirst: bool = False,
     cache_dates: bool = True,
@@ -414,8 +406,7 @@ def read_table(
     on_bad_lines: (
         Literal["error", "warn", "skip"] | Callable[[list[str]], list[str] | None]
     ) = "error",
-    delim_whitespace: bool = ...,
-    low_memory: bool = ...,
+    low_memory: bool = True,
     memory_map: bool = False,
     float_precision: Literal["high", "legacy", "round_trip"] | None = None,
     storage_options: StorageOptions | None = None,

pandas-stubs/io/sql.pyi

@@ -3,6 +3,7 @@ from collections.abc import (
     Generator,
     Iterable,
     Mapping,
+    Sequence,
 )
 import sqlite3
 from typing import (
@@ -129,13 +130,12 @@ def read_sql(
     index_col: str | list[str] | None = None,
     coerce_float: bool = True,
     params: (
-        list[Scalar]
-        | tuple[Scalar, ...]
+        Sequence[Scalar]
         | tuple[tuple[Scalar, ...], ...]
         | Mapping[str, Scalar]
         | Mapping[str, tuple[Scalar, ...]]
         | None
-    ) = ...,
+    ) = None,
     parse_dates: list[str] | dict[str, str] | dict[str, dict[str, Any]] | None = None,
     columns: list[str] | None = None,
     chunksize: None = None,