refactor: comply to more ruff and pyright rules (#1403)

* refactor(ruff): comply to F841

* fix(comment): py310 and do not ignore two pyright rules

* simplify import

Author: cmp0xff

.pre-commit-config.yaml

@@ -14,14 +14,7 @@ repos:
     rev: v0.13.3
     hooks:
     -   id: ruff-check
-        args: [
-          --exit-non-zero-on-fix,
-          --target-version, py39,
-          --extend-select, "PYI,UP,RUF100",
-          --ignore, "E501,E731,F841,PYI042",
-          --per-file-ignores, "_*.pyi:PYI001",
-          --fix
-        ]
+        args: [--exit-non-zero-on-fix]
 -   repo: https://github.com/codespell-project/codespell
     rev: v2.4.1
     hooks:

pandas-stubs/_libs/lib.pyi

@@ -2,14 +2,12 @@ from enum import Enum
 from typing import (
     Final,
     Literal,
-)
-
-import numpy as np
-from typing_extensions import (
     TypeAlias,
     TypeGuard,
 )
 
+import numpy as np
+
 class _NoDefault(Enum):
     no_default = ...
 

pandas-stubs/_libs/missing.pyi

@@ -1,6 +1,6 @@
+from collections.abc import Callable
 from typing import (
     Any,
-    Callable,
     Literal,
     overload,
 )

pandas-stubs/_libs/tslibs/nattype.pyi

@@ -4,14 +4,14 @@ from datetime import (
     timedelta,
     tzinfo as _tzinfo,
 )
-from typing import Literal
-
-import numpy as np
-from typing_extensions import (
-    Self,
+from typing import (
+    Literal,
     TypeAlias,
 )
 
+import numpy as np
+from typing_extensions import Self
+
 from pandas._libs.tslibs.period import Period
 from pandas._typing import (
     Frequency,

pandas-stubs/_libs/tslibs/period.pyi

@@ -1,6 +1,7 @@
 import datetime
 from typing import (
     Literal,
+    TypeAlias,
     overload,
 )
 
@@ -12,7 +13,6 @@ from pandas import (
     Timedelta,
     TimedeltaIndex,
 )
-from typing_extensions import TypeAlias
 
 from pandas._libs.tslibs import NaTType
 from pandas._libs.tslibs.offsets import BaseOffset

pandas-stubs/_libs/tslibs/timedeltas.pyi

@@ -5,6 +5,7 @@ from typing import (
     ClassVar,
     Literal,
     NamedTuple,
+    TypeAlias,
     overload,
 )
 
@@ -17,10 +18,7 @@ from pandas import (
     Series,
     TimedeltaIndex,
 )
-from typing_extensions import (
-    Self,
-    TypeAlias,
-)
+from typing_extensions import Self
 
 from pandas._libs.tslibs import (
     BaseOffset,

pandas-stubs/_libs/tslibs/timestamps.pyi

@@ -13,6 +13,7 @@ from typing import (
     ClassVar,
     Literal,
     SupportsIndex,
+    TypeAlias,
     overload,
 )
 
@@ -26,7 +27,6 @@ from pandas.core.series import Series
 from typing_extensions import (
     Never,
     Self,
-    TypeAlias,
 )
 
 from pandas._libs.tslibs import (

pandas-stubs/_typing.pyi

@@ -19,6 +19,7 @@ from typing import (
     Literal,
     Protocol,
     SupportsIndex,
+    TypeAlias,
     TypedDict,
     Union,
     overload,
@@ -36,7 +37,6 @@ from pandas.core.series import Series
 from pandas.core.tools.datetimes import FulldatetimeDict
 from typing_extensions import (
     ParamSpec,
-    TypeAlias,
     TypeVar,
     override,
 )

pandas-stubs/core/accessor.pyi

@@ -1,4 +1,4 @@
-from typing import Callable
+from collections.abc import Callable
 
 from pandas._typing import TypeT
 

pandas-stubs/core/arrays/datetimelike.pyi

@@ -1,15 +1,15 @@
 from collections.abc import Sequence
-from typing import overload
+from typing import (
+    TypeAlias,
+    overload,
+)
 
 import numpy as np
 from pandas.core.arrays.base import (
     ExtensionArray,
     ExtensionOpsMixin,
 )
-from typing_extensions import (
-    Self,
-    TypeAlias,
-)
+from typing_extensions import Self
 
 from pandas._libs import (
     NaT as NaT,