GH804 PR feedback

Author: loicdiridollou

pandas-stubs/core/indexes/base.pyi

@@ -315,13 +315,13 @@ class Index(IndexOpsMixin[S1]):
     def to_series(self, index=..., name: Hashable = ...) -> Series: ...
     def to_frame(self, index: bool = True, name=...) -> DataFrame: ...
     @property
-    def name(self) -> _str | None: ...
+    def name(self) -> Hashable | None: ...
     @name.setter
-    def name(self, value) -> None: ...
+    def name(self, value: Hashable) -> None: ...
     @property
-    def names(self) -> list[_str | None]: ...
+    def names(self) -> list[Hashable | None]: ...
     @names.setter
-    def names(self, names: SequenceNotStr[_str | None]) -> None: ...
+    def names(self, names: SequenceNotStr[Hashable | None]) -> None: ...
     def set_names(self, names, *, level=..., inplace: bool = ...): ...
     @overload
     def rename(self, name, *, inplace: Literal[False] = False) -> Self: ...

tests/test_indexes.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+from collections.abc import Hashable
 import datetime as dt
 from typing import (
     TYPE_CHECKING,
@@ -1439,15 +1440,17 @@ def test_index_naming() -> None:
     """
     Test index names type both for the getter and the setter.
     The names of an index should be settable with a sequence (not str) and names
-    property is a list[str | None] (FrozenList).
+    property is a list[Hashable | None] (FrozenList).
     """
     df = pd.DataFrame({"a": ["a", "b", "c"], "i": [10, 11, 12]})
 
     df.index.names = ["idx"]
-    check(assert_type(df.index.names, list[str | None]), list)
+    check(assert_type(df.index.names, list[Hashable | None]), list)
+    df.index.names = [3]
+    check(assert_type(df.index.names, list[Hashable | None]), list)
     df.index.names = ("idx2",)
-    check(assert_type(df.index.names, list[str | None]), list)
+    check(assert_type(df.index.names, list[Hashable | None]), list)
     df.index.names = [None]
-    check(assert_type(df.index.names, list[str | None]), list)
+    check(assert_type(df.index.names, list[Hashable | None]), list)
     df.index.names = (None,)
-    check(assert_type(df.index.names, list[str | None]), list)
+    check(assert_type(df.index.names, list[Hashable | None]), list)