fix: comments

Author: cmp0xff

pandas-stubs/core/indexes/accessors.pyi

@@ -7,6 +7,7 @@ from datetime import (
 from typing import (
     Generic,
     Literal,
+    Never,
     TypeVar,
     overload,
     type_check_only,
@@ -399,6 +400,8 @@ class CombinedDatetimelikeProperties(
     _TimedeltaPropertiesNoRounding[Series[int], Series[float]],
     _PeriodProperties,
 ): ...
+
+@type_check_only
 class TimestampProperties(
     DatetimeProperties[
         Series[int],
@@ -445,6 +448,8 @@ class TimedeltaIndexProperties(
 
 @type_check_only
 class DtDescriptor:
+    @overload
+    def __get__(self, instance: Series[Never], owner: type[Series]) -> Never: ...
     @overload
     def __get__(
         self, instance: Series[Timestamp], owner: type[Series]
@@ -456,6 +461,10 @@ class DtDescriptor:
 
 @type_check_only
 class ArrayDescriptor:
+    @overload
+    def __get__(
+        self, instance: IndexOpsMixin[Never], owner: type[IndexOpsMixin]
+    ) -> ExtensionArray: ...
     @overload
     def __get__(
         self, instance: IndexOpsMixin[CategoricalDtype], owner: type[IndexOpsMixin]

pyproject.toml

@@ -39,16 +39,16 @@ numpy = ">= 1.23.5"
 mypy = "1.18.2"
 pandas = "2.3.2"
 pyarrow = ">=10.0.1"
-pytest = ">=7.1.2"
+pytest = ">=8.4.2"
 pyright = ">=1.1.405"
 ty = ">=0.0.1a21"
-pyrefly = ">=0.33.1"
+pyrefly = ">=0.34.0"
 poethepoet = ">=0.16.5"
 loguru = ">=0.6.0"
 typing-extensions = ">=4.4.0"
 matplotlib = ">=3.10.1"
 pre-commit = ">=2.19.0"
-black = ">=25.1.0"
+black = ">=25.9.0"
 isort = ">=6.0.1"
 openpyxl = ">=3.0.10"
 tables = { version = ">=3.10.1", python = "<4" }

tests/indexes/test_indexes.py

@@ -1547,7 +1547,6 @@ def test_array_property() -> None:
         TimedeltaArray,
         pd.Timedelta,
     )
-    # Should be NumpyExtensionArray
     check(assert_type(Index([1]).array, ExtensionArray), ExtensionArray, np.integer)
 
 

tests/series/test_properties.py

@@ -33,7 +33,9 @@ def test_dt_property() -> None:
     )
 
     if TYPE_CHECKING_INVALID_USAGE:
-        _ = pd.Series([1]).dt  # type: ignore[arg-type] # pyright: ignore[reportAttributeAccessIssue]
+        # mypy gives Any
+        _0 = pd.Series([1, "s"]).dt  # pyright: ignore[reportAttributeAccessIssue]
+        _1 = pd.Series([1]).dt  # type: ignore[arg-type,var-annotated] # pyright: ignore[reportAttributeAccessIssue]
 
 
 def test_array_property() -> None:
@@ -55,5 +57,6 @@ def test_array_property() -> None:
         TimedeltaArray,
         pd.Timedelta,
     )
-    # Should be NumpyExtensionArray
     check(assert_type(pd.Series([1]).array, ExtensionArray), ExtensionArray, np.integer)
+    # mypy gives Any
+    check(assert_type(pd.Series([1, "s"]).array, ExtensionArray), ExtensionArray)  # type: ignore[assert-type]