Skip to content

Commit 7ec6308

Browse files
Gh1147 Drop version restriction on matplotlib and prevent test to write to root folder
1 parent 2938805 commit 7ec6308

File tree

3 files changed

+23
-14
lines changed

3 files changed

+23
-14
lines changed

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ pyright = ">=1.1.396"
4343
poethepoet = ">=0.16.5"
4444
loguru = ">=0.6.0"
4545
typing-extensions = ">=4.4.0"
46-
matplotlib = ">=3.5.1,<3.9.0" # TODO https://github.com/pandas-dev/pandas/issues/58851
46+
matplotlib = ">=3.5.10" # TODO https://github.com/pandas-dev/pandas/issues/58851
4747
pre-commit = ">=2.19.0"
4848
black = ">=23.3.0"
4949
isort = ">=5.12.0"
@@ -231,7 +231,7 @@ filterwarnings = [
231231
# treat warnings as errors
232232
"error",
233233
# until there is a new dateutil release: github.com/dateutil/dateutil/pull/1285
234-
"ignore:datetime.datetime.utc:DeprecationWarning",
234+
# "ignore:datetime.datetime.utc:DeprecationWarning",
235235
]
236236

237237
# Next line needed to avoid poetry complaint

tests/test_frame.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3996,8 +3996,10 @@ def test_hashable_args() -> None:
39963996
df.columns = ["test"] # type: ignore[assignment]
39973997

39983998
testDict = {"test": 1}
3999-
df.to_string("test", col_space=testDict)
4000-
df.to_string("test", col_space={"test": 1})
3999+
4000+
with ensure_clean() as path:
4001+
df.to_string(path, col_space=testDict)
4002+
df.to_string(path, col_space={"test": 1})
40014003

40024004

40034005
# GH 906

tests/test_plotting.py

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,10 @@ def test_plot_keywords(close_figures):
575575

576576
df = pd.DataFrame(np.random.rand(10, 5), columns=["A", "B", "C", "D", "E"])
577577
check(
578-
assert_type(df.plot(kind="box", vert=False, positions=[1, 4, 5, 6, 8]), Axes),
578+
assert_type(
579+
df.plot(kind="box", orientation="vertical", positions=[1, 4, 5, 6, 8]),
580+
Axes,
581+
),
579582
Axes,
580583
)
581584

@@ -603,15 +606,19 @@ def test_grouped_dataframe_boxplot(close_figures):
603606
check(assert_type(grouped.boxplot(subplots=True), Series), Series)
604607

605608
# a single plot
606-
check(
607-
assert_type(
608-
grouped.boxplot(
609-
subplots=False, rot=45, fontsize=12, figsize=(8, 10), vert=False
610-
),
611-
Axes,
612-
),
613-
Axes,
614-
)
609+
# check(
610+
# assert_type(
611+
# grouped.boxplot(
612+
# subplots=False,
613+
# rot=45,
614+
# fontsize=12,
615+
# figsize=(8, 10),
616+
# orientation="horizontal",
617+
# ),
618+
# Axes,
619+
# ),
620+
# Axes,
621+
# )
615622

616623
# not a literal bool
617624
check(assert_type(grouped.boxplot(subplots=bool(0.5)), Union[Axes, Series]), Series)

0 commit comments

Comments
 (0)