GHXXX PR feedback

Author: loicdiridollou

pandas-stubs/core/indexes/base.pyi

@@ -52,6 +52,7 @@ from pandas._typing import (
     Label,
     Level,
     MaskType,
+    NaPosition,
     ReindexMethod,
     SliceType,
     TimedeltaDtypeArg,
@@ -312,13 +313,6 @@ class Index(IndexOpsMixin[S1]):
     def rename(self, name, inplace: Literal[True]) -> None: ...
     @property
     def nlevels(self) -> int: ...
-    def sortlevel(
-        self,
-        level=...,
-        ascending: bool = ...,
-        sort_remaining=...,
-        na_position: Literal["first", "last"] = ...,
-    ): ...
     def get_level_values(self, level: int | _str) -> Index: ...
     def droplevel(self, level: Level | list[Level] = ...): ...
     @property
@@ -405,8 +399,8 @@ class Index(IndexOpsMixin[S1]):
         *,
         return_indexer: bool = ...,
         ascending: bool = ...,
-        na_position: Literal["first", "last"] = ...,
-        key: Callable | None = None,
+        na_position: NaPosition = ...,
+        key: Callable[[Index], Index] | None = None,
     ): ...
     def sort(self, *args, **kwargs) -> None: ...
     def argsort(self, *args, **kwargs): ...

pandas-stubs/core/indexes/multi.pyi

@@ -4,10 +4,7 @@ from collections.abc import (
     Iterable,
     Sequence,
 )
-from typing import (
-    Literal,
-    overload,
-)
+from typing import overload
 
 import numpy as np
 import pandas as pd
@@ -21,7 +18,9 @@ from pandas._typing import (
     Dtype,
     DtypeArg,
     HashableT,
+    Level,
     MaskType,
+    NaPosition,
     SequenceNotStr,
     np_ndarray_anyint,
     np_ndarray_bool,
@@ -142,10 +141,10 @@ class MultiIndex(Index):
     def reorder_levels(self, order): ...
     def sortlevel(
         self,
-        level: int = ...,
+        level: Level | Sequence[Level] = ...,
         ascending: bool = ...,
         sort_remaining: bool = ...,
-        na_position: Literal["first", "last"] = ...,
+        na_position: NaPosition = ...,
     ): ...
     def get_indexer(self, target, method=..., limit=..., tolerance=...): ...
     def get_indexer_non_unique(self, target): ...

pandas-stubs/core/resample.pyi

@@ -11,17 +11,12 @@ from typing import (
 import numpy as np
 from pandas import (
     DataFrame,
-    DatetimeIndex,
-    Index,
-    PeriodIndex,
     Series,
     Timedelta,
-    TimedeltaIndex,
 )
 from pandas.core.groupby.generic import SeriesGroupBy
 from pandas.core.groupby.groupby import BaseGroupBy
 from pandas.core.groupby.grouper import Grouper
-from pandas.core.groupby.ops import BinGrouper
 from typing_extensions import (
     Self,
     TypeAlias,
@@ -62,10 +57,6 @@ _SeriesGroupByFuncArgs: TypeAlias = (
 )
 
 class Resampler(BaseGroupBy[NDFrameT]):
-    _grouper: BinGrouper
-    binner: DatetimeIndex | TimedeltaIndex | PeriodIndex
-    exclusions: frozenset[Hashable]
-    ax: Index
     def __getattr__(self, attr: str) -> SeriesGroupBy: ...
     @overload
     def aggregate(