Skip to content

Commit 9652158

Browse files
committed
reverse overloads order, remove ellipsis when inplace=True
1 parent 13cc4bb commit 9652158

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

pandas-stubs/core/frame.pyi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -910,18 +910,18 @@ class DataFrame(NDFrame, OpsMixin):
910910
subset: Hashable | Iterable[Hashable] | None = ...,
911911
*,
912912
keep: NaPosition | _bool = ...,
913-
inplace: Literal[False] = ...,
913+
inplace: Literal[True],
914914
ignore_index: _bool = ...,
915-
) -> DataFrame: ...
915+
) -> None: ...
916916
@overload
917917
def drop_duplicates(
918918
self,
919919
subset: Hashable | Iterable[Hashable] | None = ...,
920920
*,
921921
keep: NaPosition | _bool = ...,
922-
inplace: Literal[True] = ...,
922+
inplace: Literal[False] = ...,
923923
ignore_index: _bool = ...,
924-
) -> None: ...
924+
) -> DataFrame: ...
925925
@overload
926926
def drop_duplicates(
927927
self,

pandas-stubs/core/series.pyi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -729,17 +729,17 @@ class Series(IndexOpsMixin[S1], NDFrame):
729729
self,
730730
*,
731731
keep: NaPosition | Literal[False] = ...,
732-
inplace: Literal[False] = ...,
732+
inplace: Literal[True],
733733
ignore_index: _bool = ...,
734-
) -> Series[S1]: ...
734+
) -> None: ...
735735
@overload
736736
def drop_duplicates(
737737
self,
738738
*,
739739
keep: NaPosition | Literal[False] = ...,
740-
inplace: Literal[True],
740+
inplace: Literal[False] = ...,
741741
ignore_index: _bool = ...,
742-
) -> None: ...
742+
) -> Series[S1]: ...
743743
@overload
744744
def drop_duplicates(
745745
self,

0 commit comments

Comments
 (0)