use -> T so it matches other .str methods like .str.uppercase

Author: MarcoGorelli

pandas-stubs/core/strings.pyi

@@ -68,7 +68,7 @@ class StringMethods(NoNewAttributesMixin, Generic[T, _TS, _TM, _TS2]):
         sep: str = ...,
         na_rep: str | None = ...,
         join: JoinHow = ...,
-    ) -> Series[str]: ...
+    ) -> T: ...
     @overload
     def split(
         self, pat: str = ..., *, n: int = ..., expand: Literal[True], regex: bool = ...

tests/test_series.py

@@ -66,10 +66,13 @@
         TimedeltaSeries,
         TimestampSeries,
     )
+
+    from pandas._typing import UnknownSeries
 else:
     TimedeltaSeries: TypeAlias = pd.Series
     TimestampSeries: TypeAlias = pd.Series
     OffsetSeries: TypeAlias = pd.Series
+    UnknownSeries: TypeAlias = pd.Series
 
 if TYPE_CHECKING:
     from pandas._typing import (
@@ -1667,18 +1670,16 @@ def test_series_overloads_cat():
     check(assert_type(s.str.cat(None, sep=";"), str), str)
     check(
         assert_type(
-            s.str.cat(["A", "B", "C", "D", "E", "F", "G"], sep=";"), "pd.Series[str]"
+            s.str.cat(["A", "B", "C", "D", "E", "F", "G"], sep=";"), UnknownSeries
         ),
-        pd.Series,
-        str,
+        UnknownSeries,
     )
     check(
         assert_type(
             s.str.cat(pd.Series(["A", "B", "C", "D", "E", "F", "G"]), sep=";"),
-            "pd.Series[str]",
+            UnknownSeries,
         ),
-        pd.Series,
-        str,
+        UnknownSeries,
     )