GH1173 PR Feedback

Author: loicdiridollou

pandas-stubs/core/frame.pyi

@@ -708,14 +708,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
         inplace: Literal[True],
     ) -> None: ...
     @overload
-    def query(
-        self,
-        expr: _str,
-        *,
-        inplace: Literal[True],
-        **kwargs: Any,
-    ) -> None: ...
-    @overload
     def query(
         self,
         expr: _str,
@@ -730,14 +722,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
         target: object | None = ...,
     ) -> Self: ...
     @overload
-    def query(
-        self,
-        expr: _str,
-        *,
-        inplace: Literal[False] = ...,
-        **kwargs: Any,
-    ) -> Self: ...
-    @overload
     def eval(self, expr: _str, *, inplace: Literal[True], **kwargs: Any) -> None: ...
     @overload
     def eval(

tests/test_frame.py

@@ -529,16 +529,6 @@ def test_types_query_kwargs() -> None:
         ),
         type(None),
     )
-    kwargs = {"parser": "pandas", "engine": "numexpr"}
-    check(
-        assert_type(df.query("col1 > col2", inplace=False, **kwargs), pd.DataFrame),
-        pd.DataFrame,
-    )
-
-    check(
-        assert_type(df.query("col1 % col2 == 0", inplace=True, **kwargs), None),
-        type(None),
-    )
 
 
 def test_types_eval() -> None: