fix(comment): #1274 (review)

Author: cmp0xff

pandas-stubs/core/series.pyi

@@ -1892,6 +1892,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
         self: Series[Timestamp],
         other: (
             timedelta
+            | Sequence[timedelta]
             | np.timedelta64
             | np_ndarray_td
             | TimedeltaIndex
@@ -2169,6 +2170,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
         self: Series[Timestamp],
         other: (
             timedelta
+            | Sequence[timedelta]
             | np.timedelta64
             | np_ndarray_td
             | TimedeltaIndex

tests/series/arithmetic/timestamp/test_add.py

@@ -92,16 +92,19 @@ def test_add_py_sequence() -> None:
 
     if TYPE_CHECKING_INVALID_USAGE:
         _0 = left + s  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
+        # Series[Timestamp] + Sequence[timedelta] should work, see pandas-dev/pandas#62353
         _a = left + d  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
 
         _1 = s + left  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
         _b = d + left  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
 
-        left.add(s)  # type: ignore[call-overload] # pyright: ignore[reportArgumentType,reportCallIssue]
-        left.add(d)  # type: ignore[call-overload] # pyright: ignore[reportArgumentType,reportCallIssue]
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.add(s)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
+    left.add(d)
 
-        left.radd(s)  # type: ignore[call-overload] # pyright: ignore[reportArgumentType,reportCallIssue]
-        left.radd(d)  # type: ignore[call-overload] # pyright: ignore[reportArgumentType,reportCallIssue]
+    if TYPE_CHECKING_INVALID_USAGE:
+        left.radd(s)  # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]
+    left.radd(d)
 
 
 def test_add_numpy_array() -> None:

tests/series/arithmetic/timestamp/test_sub.py

@@ -86,7 +86,9 @@ def test_sub_py_sequence() -> None:
     d = [timedelta(seconds=1)]
 
     if TYPE_CHECKING_INVALID_USAGE:
+        # Series[Timestamp] - Sequence[timestamp] should work, see pandas-dev/pandas#62353
         _0 = left - s  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
+        # Series[Timestamp] - Sequence[timedelta] should work, see pandas-dev/pandas#62353
         _a = left - d  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]
 
         _1 = s - left  # type: ignore[operator] # pyright: ignore[reportOperatorIssue]