Skip to content

Commit b4235d0

Browse files
committed
fix(comment): reduce with pytest.raises(AssertionError)
1 parent 646cdcd commit b4235d0

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

tests/series/arithmetic/str/test_add.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@
44
import numpy as np
55
from numpy import typing as npt # noqa: F401
66
import pandas as pd
7-
import pytest
87
from typing_extensions import (
9-
assert_never,
8+
Never,
109
assert_type,
1110
)
1211

@@ -73,8 +72,7 @@ def test_add_numpy_array() -> None:
7372
r0 = np.array(["a", "bc", "def"], np.str_)
7473

7574
if TYPE_CHECKING_INVALID_USAGE:
76-
with pytest.raises(AssertionError):
77-
assert_never(left + i)
75+
assert_type(left + i, Never)
7876
check(assert_type(left + r0, "pd.Series[str]"), pd.Series, str)
7977

8078
# `numpy` typing gives `npt.NDArray[np.int64]` in the static type

tests/series/arithmetic/test_add.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import pandas as pd
44
import pytest
55
from typing_extensions import (
6+
Never,
67
assert_never,
78
assert_type,
89
)
@@ -145,10 +146,8 @@ def test_add_str_py_str() -> None:
145146
s = "abc"
146147

147148
if TYPE_CHECKING_INVALID_USAGE:
148-
with pytest.raises(AssertionError):
149-
assert_never(left_i + s)
150-
with pytest.raises(AssertionError):
151-
assert_never(s + left_i)
149+
assert_type(left_i + s, Never)
150+
assert_type(s + left_i, Never)
152151
with pytest.raises(AssertionError):
153152
assert_never(left_i.add(s))
154153
with pytest.raises(AssertionError):

0 commit comments

Comments
 (0)