Skip to content

Commit bce1979

Browse files
committed
fix: missing tests
1 parent d57ec7a commit bce1979

File tree

2 files changed

+40
-2
lines changed

2 files changed

+40
-2
lines changed

pandas-stubs/core/series.pyi

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2238,7 +2238,14 @@ class Series(IndexOpsMixin[S1], NDFrame):
22382238
@overload
22392239
def truediv(
22402240
self: Series[float],
2241-
other: int | Sequence[int] | np_ndarray_anyint | np_ndarray_float | Series[int],
2241+
other: (
2242+
int
2243+
| Sequence[int]
2244+
| np_ndarray_bool
2245+
| np_ndarray_anyint
2246+
| np_ndarray_float
2247+
| Series[_T_INT]
2248+
),
22422249
level: Level | None = None,
22432250
fill_value: float | None = None,
22442251
axis: AxisIndex = 0,
@@ -2395,7 +2402,14 @@ class Series(IndexOpsMixin[S1], NDFrame):
23952402
@overload
23962403
def rtruediv(
23972404
self: Series[float],
2398-
other: int | Sequence[int] | np_ndarray_anyint | np_ndarray_float | Series[int],
2405+
other: (
2406+
int
2407+
| Sequence[int]
2408+
| np_ndarray_bool
2409+
| np_ndarray_anyint
2410+
| np_ndarray_float
2411+
| Series[_T_INT]
2412+
),
23992413
level: Level | None = None,
24002414
fill_value: float | None = None,
24012415
axis: AxisIndex = 0,

tests/series/arithmetic/float/test_truediv.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,17 @@ def test_truediv_py_scalar() -> None:
1212
"""Test pd.Series[float] / Python native scalars"""
1313
b, i, f, c = True, 1, 1.0, 1j
1414

15+
check(assert_type(left / b, "pd.Series[float]"), pd.Series, np.floating)
1516
check(assert_type(left / i, "pd.Series[float]"), pd.Series, np.floating)
1617
check(assert_type(left / f, "pd.Series[float]"), pd.Series, np.floating)
1718
check(assert_type(left / c, "pd.Series[complex]"), pd.Series, np.complexfloating)
1819

20+
check(assert_type(b / left, "pd.Series[float]"), pd.Series, np.floating)
1921
check(assert_type(i / left, "pd.Series[float]"), pd.Series, np.floating)
2022
check(assert_type(f / left, "pd.Series[float]"), pd.Series, np.floating)
2123
check(assert_type(c / left, "pd.Series[complex]"), pd.Series, np.complexfloating)
2224

25+
check(assert_type(left.truediv(b), "pd.Series[float]"), pd.Series, np.floating)
2326
check(assert_type(left.truediv(i), "pd.Series[float]"), pd.Series, np.floating)
2427
check(assert_type(left.truediv(f), "pd.Series[float]"), pd.Series, np.floating)
2528
check(
@@ -28,10 +31,12 @@ def test_truediv_py_scalar() -> None:
2831
np.complexfloating,
2932
)
3033

34+
check(assert_type(left.div(b), "pd.Series[float]"), pd.Series, np.floating)
3135
check(assert_type(left.div(i), "pd.Series[float]"), pd.Series, np.floating)
3236
check(assert_type(left.div(f), "pd.Series[float]"), pd.Series, np.floating)
3337
check(assert_type(left.div(c), "pd.Series[complex]"), pd.Series, np.complexfloating)
3438

39+
check(assert_type(left.rtruediv(b), "pd.Series[float]"), pd.Series, np.floating)
3540
check(assert_type(left.rtruediv(i), "pd.Series[float]"), pd.Series, np.floating)
3641
check(assert_type(left.rtruediv(f), "pd.Series[float]"), pd.Series, np.floating)
3742
check(
@@ -40,6 +45,7 @@ def test_truediv_py_scalar() -> None:
4045
np.complexfloating,
4146
)
4247

48+
check(assert_type(left.rdiv(b), "pd.Series[float]"), pd.Series, np.floating)
4349
check(assert_type(left.rdiv(i), "pd.Series[float]"), pd.Series, np.floating)
4450
check(assert_type(left.rdiv(f), "pd.Series[float]"), pd.Series, np.floating)
4551
check(
@@ -51,14 +57,17 @@ def test_truediv_py_sequence() -> None:
5157
"""Test pd.Series[float] / Python native sequence"""
5258
b, i, f, c = [True, False, True], [2, 3, 5], [1.0, 2.0, 3.0], [1j, 1j, 4j]
5359

60+
check(assert_type(left / b, "pd.Series[float]"), pd.Series, np.floating)
5461
check(assert_type(left / i, "pd.Series[float]"), pd.Series, np.floating)
5562
check(assert_type(left / f, "pd.Series[float]"), pd.Series, np.floating)
5663
check(assert_type(left / c, "pd.Series[complex]"), pd.Series, np.complexfloating)
5764

65+
check(assert_type(b / left, "pd.Series[float]"), pd.Series, np.floating)
5866
check(assert_type(i / left, "pd.Series[float]"), pd.Series, np.floating)
5967
check(assert_type(f / left, "pd.Series[float]"), pd.Series, np.floating)
6068
check(assert_type(c / left, "pd.Series[complex]"), pd.Series, np.complexfloating)
6169

70+
check(assert_type(left.truediv(b), "pd.Series[float]"), pd.Series, np.floating)
6271
check(assert_type(left.truediv(i), "pd.Series[float]"), pd.Series, np.floating)
6372
check(assert_type(left.truediv(f), "pd.Series[float]"), pd.Series, np.floating)
6473
check(
@@ -67,10 +76,12 @@ def test_truediv_py_sequence() -> None:
6776
np.complexfloating,
6877
)
6978

79+
check(assert_type(left.div(b), "pd.Series[float]"), pd.Series, np.floating)
7080
check(assert_type(left.div(i), "pd.Series[float]"), pd.Series, np.floating)
7181
check(assert_type(left.div(f), "pd.Series[float]"), pd.Series, np.floating)
7282
check(assert_type(left.div(c), "pd.Series[complex]"), pd.Series, np.complexfloating)
7383

84+
check(assert_type(left.rtruediv(b), "pd.Series[float]"), pd.Series, np.floating)
7485
check(assert_type(left.rtruediv(i), "pd.Series[float]"), pd.Series, np.floating)
7586
check(assert_type(left.rtruediv(f), "pd.Series[float]"), pd.Series, np.floating)
7687
check(
@@ -79,6 +90,7 @@ def test_truediv_py_sequence() -> None:
7990
np.complexfloating,
8091
)
8192

93+
check(assert_type(left.rdiv(b), "pd.Series[float]"), pd.Series, np.floating)
8294
check(assert_type(left.rdiv(i), "pd.Series[float]"), pd.Series, np.floating)
8395
check(assert_type(left.rdiv(f), "pd.Series[float]"), pd.Series, np.floating)
8496
check(
@@ -93,13 +105,15 @@ def test_truediv_numpy_array() -> None:
93105
f = np.array([1.0, 2.0, 3.0], np.float64)
94106
c = np.array([1.1j, 2.2j, 4.1j], np.complex128)
95107

108+
check(assert_type(left / b, "pd.Series[float]"), pd.Series, np.floating)
96109
check(assert_type(left / i, "pd.Series[float]"), pd.Series, np.floating)
97110
check(assert_type(left / f, "pd.Series[float]"), pd.Series, np.floating)
98111
check(assert_type(left / c, "pd.Series[complex]"), pd.Series, np.complexfloating)
99112

100113
# `numpy` typing gives the corresponding `ndarray`s in the static type
101114
# checking, where our `__rtruediv__` cannot override. At runtime, they return
102115
# `Series`s with the correct element type.
116+
check(assert_type(b / left, "npt.NDArray[np.float64]"), pd.Series, np.floating)
103117
check(assert_type(i / left, "npt.NDArray[np.float64]"), pd.Series, np.floating)
104118
check(assert_type(f / left, "npt.NDArray[np.float64]"), pd.Series, np.floating)
105119
check(
@@ -108,6 +122,7 @@ def test_truediv_numpy_array() -> None:
108122
np.complexfloating,
109123
)
110124

125+
check(assert_type(left.truediv(b), "pd.Series[float]"), pd.Series, np.floating)
111126
check(assert_type(left.truediv(i), "pd.Series[float]"), pd.Series, np.floating)
112127
check(assert_type(left.truediv(f), "pd.Series[float]"), pd.Series, np.floating)
113128
check(
@@ -116,10 +131,12 @@ def test_truediv_numpy_array() -> None:
116131
np.complexfloating,
117132
)
118133

134+
check(assert_type(left.div(b), "pd.Series[float]"), pd.Series, np.floating)
119135
check(assert_type(left.div(i), "pd.Series[float]"), pd.Series, np.floating)
120136
check(assert_type(left.div(f), "pd.Series[float]"), pd.Series, np.floating)
121137
check(assert_type(left.div(c), "pd.Series[complex]"), pd.Series, np.complexfloating)
122138

139+
check(assert_type(left.rtruediv(b), "pd.Series[float]"), pd.Series, np.floating)
123140
check(assert_type(left.rtruediv(i), "pd.Series[float]"), pd.Series, np.floating)
124141
check(assert_type(left.rtruediv(f), "pd.Series[float]"), pd.Series, np.floating)
125142
check(
@@ -128,6 +145,7 @@ def test_truediv_numpy_array() -> None:
128145
np.complexfloating,
129146
)
130147

148+
check(assert_type(left.rdiv(b), "pd.Series[float]"), pd.Series, np.floating)
131149
check(assert_type(left.rdiv(i), "pd.Series[float]"), pd.Series, np.floating)
132150
check(assert_type(left.rdiv(f), "pd.Series[float]"), pd.Series, np.floating)
133151
check(
@@ -142,14 +160,17 @@ def test_truediv_pd_series() -> None:
142160
f = pd.Series([1.0, 2.0, 3.0])
143161
c = pd.Series([1.1j, 2.2j, 4.1j])
144162

163+
check(assert_type(left / b, "pd.Series[float]"), pd.Series, np.floating)
145164
check(assert_type(left / i, "pd.Series[float]"), pd.Series, np.floating)
146165
check(assert_type(left / f, "pd.Series[float]"), pd.Series, np.floating)
147166
check(assert_type(left / c, "pd.Series[complex]"), pd.Series, np.complexfloating)
148167

168+
check(assert_type(b / left, "pd.Series[float]"), pd.Series, np.floating)
149169
check(assert_type(i / left, "pd.Series[float]"), pd.Series, np.floating)
150170
check(assert_type(f / left, "pd.Series[float]"), pd.Series, np.floating)
151171
check(assert_type(c / left, "pd.Series[complex]"), pd.Series, np.complexfloating)
152172

173+
check(assert_type(left.truediv(b), "pd.Series[float]"), pd.Series, np.floating)
153174
check(assert_type(left.truediv(i), "pd.Series[float]"), pd.Series, np.floating)
154175
check(assert_type(left.truediv(f), "pd.Series[float]"), pd.Series, np.floating)
155176
check(
@@ -158,10 +179,12 @@ def test_truediv_pd_series() -> None:
158179
np.complexfloating,
159180
)
160181

182+
check(assert_type(left.div(b), "pd.Series[float]"), pd.Series, np.floating)
161183
check(assert_type(left.div(i), "pd.Series[float]"), pd.Series, np.floating)
162184
check(assert_type(left.div(f), "pd.Series[float]"), pd.Series, np.floating)
163185
check(assert_type(left.div(c), "pd.Series[complex]"), pd.Series, np.complexfloating)
164186

187+
check(assert_type(left.rtruediv(b), "pd.Series[float]"), pd.Series, np.floating)
165188
check(assert_type(left.rtruediv(i), "pd.Series[float]"), pd.Series, np.floating)
166189
check(assert_type(left.rtruediv(f), "pd.Series[float]"), pd.Series, np.floating)
167190
check(
@@ -170,6 +193,7 @@ def test_truediv_pd_series() -> None:
170193
np.complexfloating,
171194
)
172195

196+
check(assert_type(left.rdiv(b), "pd.Series[float]"), pd.Series, np.floating)
173197
check(assert_type(left.rdiv(i), "pd.Series[float]"), pd.Series, np.floating)
174198
check(assert_type(left.rdiv(f), "pd.Series[float]"), pd.Series, np.floating)
175199
check(

0 commit comments

Comments
 (0)