fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1274/files#r2229581983

Author: cmp0xff

pandas-stubs/_typing.pyi

@@ -824,7 +824,7 @@ MaskType: TypeAlias = Series[bool] | np_ndarray_bool | list[bool]
 
 # Scratch types for generics
 
-# Closure upon add, sub, mul
+# Closure upon add and mul
 SeriesDTypeClosure: TypeAlias = (
     str
     | bytes

pandas-stubs/core/indexes/accessors.pyi

@@ -319,7 +319,7 @@ class TimedeltaProperties(
 ):
     @property
     def unit(self) -> TimeUnit: ...
-    def as_unit(self, unit: TimeUnit) -> TimedeltaSeries: ...
+    def as_unit(self, unit: TimeUnit) -> Series[Timedelta]: ...
 
 _PeriodDTReturnTypes = TypeVar(
     "_PeriodDTReturnTypes", bound=Series[Timestamp] | DatetimeIndex
@@ -438,6 +438,10 @@ class _dtDescriptor(CombinedDatetimelikeProperties, Generic[S1]):
         self, instance: Series[Timestamp], owner: Any
     ) -> TimestampProperties: ...
     @overload
+    def __get__(
+        self, instance: Series[Timedelta], owner: Any
+    ) -> TimedeltaProperties: ...
+    @overload
     def __get__(
         self, instance: Series[S1], owner: Any
     ) -> CombinedDatetimelikeProperties: ...

pandas-stubs/core/series.pyi

@@ -2831,7 +2831,7 @@ class TimedeltaSeries(Series[Timedelta]):
         self, other: num | Sequence[num] | Series[int] | Series[float]
     ) -> TimedeltaSeries: ...
     def unique(self) -> TimedeltaArray: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
-    def __sub__(  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
+    def __sub__(  # type: ignore[override]
         self,
         other: (
             timedelta | Timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64
@@ -2889,7 +2889,9 @@ class TimedeltaSeries(Series[Timedelta]):
         ),
     ) -> Series[int]: ...
     @property
-    def dt(self) -> TimedeltaProperties: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
+    def dt(
+        self,
+    ) -> TimedeltaProperties: ...  # pyright: ignore[reportIncompatibleMethodOverride]
     def mean(  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
         self,
         axis: AxisIndex | None = ...,
@@ -2934,7 +2936,7 @@ class TimedeltaSeries(Series[Timedelta]):
 class PeriodSeries(Series[Period]):
     @property
     def dt(self) -> PeriodProperties: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
-    def __sub__(self, other: PeriodSeries) -> OffsetSeries: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
+    def __sub__(self, other: PeriodSeries) -> OffsetSeries: ...  # type: ignore[override]
     def diff(self, periods: int = ...) -> OffsetSeries: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
     def cumprod(
         self,

tests/test_timefuncs.py

@@ -584,10 +584,26 @@ def test_series_dt_accessors() -> None:
         check(assert_type(s2.dt.to_pytimedelta(), np.ndarray), np.ndarray)
     check(assert_type(s2.dt.total_seconds(), "pd.Series[float]"), pd.Series, float)
     check(assert_type(s2.dt.unit, TimeUnit), str)
-    check(assert_type(s2.dt.as_unit("s"), "TimedeltaSeries"), pd.Series, pd.Timedelta)
-    check(assert_type(s2.dt.as_unit("ms"), "TimedeltaSeries"), pd.Series, pd.Timedelta)
-    check(assert_type(s2.dt.as_unit("us"), "TimedeltaSeries"), pd.Series, pd.Timedelta)
-    check(assert_type(s2.dt.as_unit("ns"), "TimedeltaSeries"), pd.Series, pd.Timedelta)
+    check(
+        assert_type(s2.dt.as_unit("s"), "pd.Series[pd.Timedelta]"),
+        pd.Series,
+        pd.Timedelta,
+    )
+    check(
+        assert_type(s2.dt.as_unit("ms"), "pd.Series[pd.Timedelta]"),
+        pd.Series,
+        pd.Timedelta,
+    )
+    check(
+        assert_type(s2.dt.as_unit("us"), "pd.Series[pd.Timedelta]"),
+        pd.Series,
+        pd.Timedelta,
+    )
+    check(
+        assert_type(s2.dt.as_unit("ns"), "pd.Series[pd.Timedelta]"),
+        pd.Series,
+        pd.Timedelta,
+    )
 
     # Checks for general Series other than Series[Timestamp] and TimedeltaSeries
 
@@ -622,22 +638,22 @@ def test_series_dt_accessors() -> None:
 
     check(assert_type(s5.dt.unit, TimeUnit), str)
     check(
-        assert_type(s5.dt.as_unit("s"), "pd.Series[pd.Timedelta]"),  # type: ignore[assert-type]
+        assert_type(s5.dt.as_unit("s"), "pd.Series[pd.Timedelta]"),
         pd.Series,
         pd.Timedelta,
     )
     check(
-        assert_type(s5.dt.as_unit("ms"), "pd.Series[pd.Timedelta]"),  # type: ignore[assert-type]
+        assert_type(s5.dt.as_unit("ms"), "pd.Series[pd.Timedelta]"),
         pd.Series,
         pd.Timedelta,
     )
     check(
-        assert_type(s5.dt.as_unit("us"), "pd.Series[pd.Timedelta]"),  # type: ignore[assert-type]
+        assert_type(s5.dt.as_unit("us"), "pd.Series[pd.Timedelta]"),
         pd.Series,
         pd.Timedelta,
     )
     check(
-        assert_type(s5.dt.as_unit("ns"), "pd.Series[pd.Timedelta]"),  # type: ignore[assert-type]
+        assert_type(s5.dt.as_unit("ns"), "pd.Series[pd.Timedelta]"),
         pd.Series,
         pd.Timedelta,
     )