simplify skip_platform

Author: cmp0xff

tests/__init__.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-from collections.abc import Callable
 from contextlib import (
     AbstractContextManager,
     nullcontext,
@@ -10,7 +9,6 @@
 import sys
 from typing import (
     TYPE_CHECKING,
-    Any,
     Final,
     Literal,
     TypeAlias,
@@ -468,6 +466,7 @@
 LINUX = sys.platform == "linux"
 WINDOWS = sys.platform in {"win32", "cygwin"}
 MAC = sys.platform == "darwin"
+MAC_ARM = sys.platform == "darwin" and platform.processor() == "arm64"
 PD_LTE_23 = Version(pd.__version__) < Version("2.3.999")
 NUMPY20 = np.lib.NumpyVersion(np.__version__) >= "2.0.0"
 
@@ -673,13 +672,5 @@ def pytest_warns_bounded(
     return suppress(upper_exception)
 
 
-def skip_platform(
-    raise_type_error: Callable[[], Any], dtype: type | str | ExtensionDtype
-) -> None:
-    system = platform.system()
-    if (
-        system == "Windows" or system == "Darwin" and platform.processor() == "arm"
-    ) and dtype in {"f16", "float128"}:
-        with pytest.raises(TypeError):
-            raise_type_error()
-        pytest.skip(f"{system} does not support {dtype}")
+def skip_platform(dtype: type | str | ExtensionDtype) -> bool:
+    return (WINDOWS or MAC_ARM) and dtype in {"f16", "float128"}

tests/arrays/test_floating_array.py

@@ -32,12 +32,11 @@ def test_constructor() -> None:
 
 @pytest.mark.parametrize(("dtype", "target_dtype"), PANDAS_FLOAT_ARGS.items(), ids=repr)
 def test_constructor_dtype(dtype: PandasFloatDtypeArg, target_dtype: type) -> None:
-    def maker() -> FloatingArray:
-        return assert_type(pd.array([1.0], dtype=dtype), FloatingArray)
-
-    skip_platform(maker, dtype)
-
-    check(maker(), FloatingArray, target_dtype)
+    if skip_platform(dtype):
+        with pytest.raises(TypeError):
+            assert_type(pd.array([1.0], dtype=dtype), FloatingArray)
+    else:
+        check(pd.array([1.0], dtype=dtype), FloatingArray, target_dtype)
 
     if TYPE_CHECKING:
         # pandas Float32

tests/indexes/test_index_float.py

@@ -52,17 +52,11 @@ def test_constructor() -> None:
 def test_constructor_dtype(
     dtype: "FloatNotNumpy16DtypeArg", target_dtype: type
 ) -> None:
-    def maker() -> "pd.Index[float]":
-        return assert_type(pd.Index([1.0], dtype=dtype), "pd.Index[float]")
-
-    skip_platform(maker, dtype)
-    if target_dtype is np.float16:
-        reason = r"float16 indexes are not supported"
-        with pytest.raises(NotImplementedError, match=reason):
-            maker()
-        pytest.skip(reason)
-
-    check(maker(), pd.Index, target_dtype)
+    if skip_platform(dtype):
+        with pytest.raises(TypeError):
+            assert_type(pd.Index([1.0], dtype=dtype), "pd.Index[float]")
+    else:
+        check(pd.Index([1.0], dtype=dtype), pd.Index, target_dtype)
 
     if TYPE_CHECKING:
         # python float
@@ -116,9 +110,11 @@ def test_astype_float(
 ) -> None:
     s = pd.Index([1, 2, 3])
 
-    skip_platform(lambda: s.astype(cast_arg), cast_arg)
-
-    check(s.astype(cast_arg), pd.Index, target_type)
+    if skip_platform(cast_arg):
+        with pytest.raises(TypeError):
+            assert_type(s.astype(cast_arg), "pd.Index[float]")
+    else:
+        check(s.astype(cast_arg), pd.Index, target_type)
 
     if TYPE_CHECKING:
         # python float

tests/series/test_series_float.py

@@ -46,12 +46,12 @@ def test_constructor() -> None:
 
 @pytest.mark.parametrize(("dtype", "target_dtype"), TYPE_FLOAT_ARGS.items())
 def test_constructor_dtype(dtype: FloatDtypeArg, target_dtype: type) -> None:
-    def maker() -> "pd.Series[float]":
-        return assert_type(pd.Series([1.0], dtype=dtype), "pd.Series[float]")
+    if skip_platform(dtype):
+        with pytest.raises(TypeError):
+            assert_type(pd.Series([1.0], dtype=dtype), "pd.Series[float]")
+    else:
+        check(pd.Series([1.0], dtype=dtype), pd.Series, target_dtype)
 
-    skip_platform(maker, dtype)
-
-    check(maker(), pd.Series, target_dtype)
     if TYPE_CHECKING:
         # python float
         assert_type(pd.Series([1.0], dtype=float), "pd.Series[float]")
@@ -102,9 +102,11 @@ def test_astype_float(
 ) -> None:
     s = pd.Series([1, 2, 3])
 
-    skip_platform(lambda: s.astype(cast_arg), cast_arg)
-
-    check(s.astype(cast_arg), pd.Series, target_type)
+    if skip_platform(cast_arg):
+        with pytest.raises(TypeError):
+            assert_type(s.astype(cast_arg), "pd.Series[float]")
+    else:
+        check(s.astype(cast_arg), pd.Series, target_type)
 
     if TYPE_CHECKING:
         # python float