fix(comment): avoid union types #1282 (comment)

Author: cmp0xff

pandas-stubs/core/indexes/base.pyi

@@ -43,7 +43,6 @@ from typing_extensions import (
 from pandas._libs.interval import _OrderableT
 from pandas._typing import (
     S1,
-    S2,
     AnyAll,
     AxesData,
     DropKeep,
@@ -405,9 +404,7 @@ class Index(IndexOpsMixin[S1]):
     @overload
     def append(self, other: Index[S1] | Sequence[Index[S1]]) -> Self: ...
     @overload
-    def append(self, other: Index[S2]) -> Index[S1 | S2]: ...
-    @overload
-    def append(self, other: Sequence[Index]) -> Index: ...
+    def append(self, other: Index | Sequence[Index]) -> Index: ...
     def putmask(self, mask, value): ...
     def equals(self, other) -> bool: ...
     @final

tests/test_indexes.py

@@ -1031,19 +1031,14 @@ def test_getitem() -> None:
 
 
 def test_append_mix() -> None:
-    """Test pd.Index.append that gives pd.Index[Any]"""
+    """Test pd.Index.append with mixed types"""
     first = pd.Index([1])
     second = pd.Index(["a"])
     third = pd.Index([1, "a"])
-    check(assert_type(first.append(second), "pd.Index[int | str]"), pd.Index)
+    check(assert_type(first.append(second), pd.Index), pd.Index)
     check(assert_type(first.append([second]), pd.Index), pd.Index)
 
-    check(
-        assert_type(  # type: ignore[assert-type]
-            first.append(third), "pd.Index[int | str]"
-        ),
-        pd.Index,
-    )
+    check(assert_type(first.append(third), pd.Index), pd.Index)
     check(assert_type(first.append([third]), pd.Index), pd.Index)
     check(assert_type(first.append([second, third]), pd.Index), pd.Index)