GH1037 PR feedback

Author: loicdiridollou

pandas-stubs/core/algorithms.pyi

@@ -52,17 +52,13 @@ def factorize(
 def factorize(
     values: Index | Series,
     sort: bool = ...,
-    # Not actually positional-only, used to handle deprecations in 1.5.0
-    *,
     use_na_sentinel: bool = ...,
     size_hint: int | None = ...,
 ) -> tuple[np.ndarray, Index]: ...
 @overload
 def factorize(
     values: Categorical,
     sort: bool = ...,
-    # Not actually positional-only, used to handle deprecations in 1.5.0
-    *,
     use_na_sentinel: bool = ...,
     size_hint: int | None = ...,
 ) -> tuple[np.ndarray, Categorical]: ...

pandas-stubs/core/arrays/base.pyi

@@ -42,9 +42,7 @@ class ExtensionArray:
     def shift(self, periods: int = ..., fill_value: object = ...) -> Self: ...
     def unique(self): ...
     def searchsorted(self, value, side: str = ..., sorter=...): ...
-    def factorize(
-        self, sort: bool = ..., use_na_sentinel: bool = ...
-    ) -> tuple[np.ndarray, Self]: ...
+    def factorize(self, use_na_sentinel: bool = ...) -> tuple[np.ndarray, Self]: ...
     def repeat(self, repeats, axis=...): ...
     def take(
         self,