address more comments

Author: yangdanny97

pandas-stubs/core/groupby/generic.pyi

@@ -179,7 +179,7 @@ class SeriesGroupBy(GroupBy[Series[S2]], Generic[S2, ByT]):
     def cov(
         self,
         other: Series,
-        min_periods: int | None = ...,
+        min_periods: int | None = None,
         ddof: int | None = 1,
     ) -> Series: ...
     @property
@@ -188,8 +188,8 @@ class SeriesGroupBy(GroupBy[Series[S2]], Generic[S2, ByT]):
     def is_monotonic_decreasing(self) -> Series[bool]: ...
     def hist(
         self,
-        by: IndexLabel | None = ...,
-        ax: PlotAxes | None = ...,
+        by: IndexLabel | None = None,
+        ax: PlotAxes | None = None,
         grid: bool = True,
         xlabelsize: float | str | None = None,
         xrot: float | None = None,
@@ -424,18 +424,18 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
     ) -> DataFrame: ...
     def hist(
         self,
-        column: IndexLabel | None = ...,
-        by: IndexLabel | None = ...,
+        column: IndexLabel | None = None,
+        by: IndexLabel | None = None,
         grid: bool = True,
         xlabelsize: float | str | None = None,
         xrot: float | None = None,
         ylabelsize: float | str | None = None,
         yrot: float | None = None,
         ax: PlotAxes | None = None,
-        sharex: bool = ...,
+        sharex: bool = False,
         sharey: bool = False,
-        figsize: tuple[float, float] | None = ...,
-        layout: tuple[int, int] | None = ...,
+        figsize: tuple[float, float] | None = None,
+        layout: tuple[int, int] | None = None,
         bins: int | Sequence[int] = 10,
         backend: str | None = None,
         legend: bool = False,

pandas-stubs/core/groupby/groupby.pyi

@@ -177,9 +177,13 @@ class GroupBy(BaseGroupBy[NDFrameT]):
         engine_kwargs: WindowingEngineKwargs = None,
     ) -> NDFrameT: ...
     @final
-    def first(self, numeric_only: bool = False, min_count: int = -1) -> NDFrameT: ...
+    def first(
+        self, numeric_only: bool = False, min_count: int = -1, skipna: bool = True
+    ) -> NDFrameT: ...
     @final
-    def last(self, numeric_only: bool = False, min_count: int = -1) -> NDFrameT: ...
+    def last(
+        self, numeric_only: bool = False, min_count: int = -1, skipna: bool = True
+    ) -> NDFrameT: ...
     @final
     def ohlc(self) -> DataFrame: ...
     def describe(
@@ -215,11 +219,11 @@ class GroupBy(BaseGroupBy[NDFrameT]):
         center: bool | None = False,
         win_type: str | None = None,
         axis: Axis = 0,
-        on: str | Index | None = ...,
+        on: str | Index | None = None,
         closed: IntervalClosedType | None = None,
         method: CalculationMethod = "single",
         *,
-        selection: IndexLabel | None = ...,
+        selection: IndexLabel | None = None,
     ) -> RollingGroupby[NDFrameT]: ...
     @final
     def expanding(
@@ -256,7 +260,7 @@ class GroupBy(BaseGroupBy[NDFrameT]):
     def quantile(
         self,
         q: float | AnyArrayLike = 0.5,
-        interpolation: str = ...,
+        interpolation: str = "linear",
         numeric_only: bool = False,
     ) -> NDFrameT: ...
     @final
@@ -323,8 +327,8 @@ class GroupBy(BaseGroupBy[NDFrameT]):
     @final
     def sample(
         self,
-        n: int | None = ...,
-        frac: float | None = ...,
+        n: int | None = None,
+        frac: float | None = None,
         replace: bool = False,
         weights: Sequence | Series | None = ...,
         random_state: RandomState | None = ...,
@@ -371,7 +375,7 @@ class BaseGroupBy(SelectionMixin[NDFrameT], GroupByIndexingMixin):
         **kwargs: Any,
     ) -> T: ...
     @final
-    def get_group(self, name, obj: NDFrameT | None = None) -> NDFrameT: ...
+    def get_group(self, name) -> NDFrameT: ...
     @final
     def __iter__(self) -> Iterator[tuple[Hashable, NDFrameT]]: ...
     @overload

pandas-stubs/core/indexes/base.pyi

@@ -44,16 +44,19 @@ from pandas._libs.interval import _OrderableT
 from pandas._typing import (
     S1,
     AnyAll,
+    ArrayLike,
     AxesData,
     DropKeep,
     DtypeArg,
     DtypeObj,
     HashableT,
+    IgnoreRaise,
     Label,
     Level,
     MaskType,
     NaPosition,
     ReindexMethod,
+    Scalar,
     SliceType,
     TimedeltaDtypeArg,
     TimestampDtypeArg,
@@ -290,9 +293,9 @@ class Index(IndexOpsMixin[S1]):
     def take(
         self,
         indices,
-        axis: int = ...,
+        axis: int = 0,
         allow_fill: bool = True,
-        fill_value=None,
+        fill_value: Scalar | None = None,
         **kwargs,
     ): ...
     def repeat(self, repeats, axis=...): ...
@@ -397,7 +400,7 @@ class Index(IndexOpsMixin[S1]):
     @property
     def array(self) -> ExtensionArray: ...
     def memory_usage(self, deep: bool = False): ...
-    def where(self, cond, other=None): ...
+    def where(self, cond, other: Scalar | ArrayLike | None = None): ...
     def __contains__(self, key) -> bool: ...
     @final
     def __setitem__(self, key, value) -> None: ...
@@ -434,12 +437,19 @@ class Index(IndexOpsMixin[S1]):
     def groupby(self, values) -> dict[Hashable, np.ndarray]: ...
     def map(self, mapper, na_action=...) -> Index: ...
     def isin(self, values, level=...) -> np_ndarray_bool: ...
-    def slice_indexer(self, start=None, end=None, step=None): ...
+    def slice_indexer(
+        self,
+        start: Label | None = None,
+        end: Label | None = None,
+        step: int | None = None,
+    ): ...
     def get_slice_bound(self, label, side): ...
-    def slice_locs(self, start: SliceType = None, end: SliceType = None, step=...): ...
+    def slice_locs(
+        self, start: SliceType = None, end: SliceType = None, step: int | None = None
+    ): ...
     def delete(self, loc) -> Self: ...
     def insert(self, loc, item) -> Self: ...
-    def drop(self, labels, errors: _str = "raise") -> Self: ...
+    def drop(self, labels, errors: IgnoreRaise = "raise") -> Self: ...
     @property
     def shape(self) -> tuple[int, ...]: ...
     # Extra methods from old stubs

pandas-stubs/core/indexes/category.pyi

@@ -3,7 +3,6 @@ from collections.abc import (
     Iterable,
 )
 from typing import (
-    Literal,
     final,
 )
 
@@ -39,7 +38,6 @@ class CategoricalIndex(ExtensionIndex[S1], accessor.PandasDelegate):
     def __array__(
         self, dtype: DtypeArg = ..., copy: bool | None = ...
     ) -> np.ndarray: ...
-    def astype(self, dtype: DtypeArg, copy: bool = True) -> Index: ...
     def fillna(self, value=...): ...
     @property
     def is_unique(self) -> bool: ...
@@ -48,9 +46,6 @@ class CategoricalIndex(ExtensionIndex[S1], accessor.PandasDelegate):
     @property
     def is_monotonic_decreasing(self) -> bool: ...
     def unique(self, level=...): ...
-    def duplicated(self, keep: Literal["first", "last", False] = "first"): ...
-    @final
-    def where(self, cond, other=None): ...
     def reindex(self, target, method=..., level=..., limit=..., tolerance=...): ...
     @final
     def get_indexer(self, target, method=..., limit=..., tolerance=...): ...

pandas-stubs/core/indexes/datetimelike.pyi

@@ -1,12 +1,10 @@
-import numpy as np
 from pandas.core.indexes.extension import ExtensionIndex
 from pandas.core.indexes.timedeltas import TimedeltaIndex
 from typing_extensions import Self
 
 from pandas._libs.tslibs import BaseOffset
 from pandas._typing import (
     S1,
-    AxisIndex,
     TimeUnit,
 )
 
@@ -17,34 +15,6 @@ class DatetimeIndexOpsMixin(ExtensionIndex[S1]):
     def freqstr(self) -> str | None: ...
     @property
     def is_all_dates(self) -> bool: ...
-    def min(
-        self,
-        axis: AxisIndex | None = ...,
-        skipna: bool = True,
-        *args,
-        **kwargs,
-    ) -> S1: ...
-    def argmin(
-        self,
-        axis: AxisIndex | None = ...,
-        skipna: bool = True,
-        *args,
-        **kwargs,
-    ) -> np.int64: ...
-    def max(
-        self,
-        axis: AxisIndex | None = ...,
-        skipna: bool = True,
-        *args,
-        **kwargs,
-    ) -> S1: ...
-    def argmax(
-        self,
-        axis: AxisIndex | None = ...,
-        skipna: bool = True,
-        *args,
-        **kwargs,
-    ) -> np.int64: ...
     def __rsub__(  # type: ignore[override]
         self, other: DatetimeIndexOpsMixin
     ) -> TimedeltaIndex: ...

pandas-stubs/core/indexes/datetimes.pyi

@@ -28,6 +28,7 @@ from pandas.core.series import (
 )
 from typing_extensions import Self
 
+from pandas._libs.tslibs.offsets import DateOffset
 from pandas._typing import (
     AxesData,
     DateAndDatetimeLike,
@@ -85,8 +86,8 @@ class DatetimeIndex(DatetimeTimedeltaMixin[Timestamp], DatetimeIndexProperties):
     def indexer_at_time(self, time, asof: bool = ...): ...
     def indexer_between_time(
         self,
-        start_time,
-        end_time,
+        start_time: datetime | str,
+        end_time: datetime | str,
         include_start: bool = True,
         include_end: bool = True,
     ): ...
@@ -96,7 +97,9 @@ class DatetimeIndex(DatetimeTimedeltaMixin[Timestamp], DatetimeIndexProperties):
     def tzinfo(self) -> _tzinfo | None: ...
     @property
     def dtype(self) -> np.dtype | DatetimeTZDtype: ...
-    def shift(self, periods: int = 1, freq=...) -> Self: ...
+    def shift(
+        self, periods: int = 1, freq: DateOffset | Timedelta | str | None = None
+    ) -> Self: ...
 
 def date_range(
     start: str | DateAndDatetimeLike | None = None,

pandas-stubs/core/indexes/multi.pyi

@@ -19,8 +19,8 @@ from pandas._typing import (
     Axes,
     DropKeep,
     Dtype,
-    DtypeArg,
     HashableT,
+    IndexLabel,
     Level,
     MaskType,
     NaPosition,
@@ -132,27 +132,17 @@ class MultiIndex(Index):
     def __getitem__(  # pyright: ignore[reportIncompatibleMethodOverride]
         self, key: int
     ) -> tuple: ...
-    def take(
-        self,
-        indices,
-        axis: int = ...,
-        allow_fill: bool = True,
-        fill_value=None,
-        **kwargs,
-    ): ...
     def append(self, other): ...
     def argsort(self, *args, **kwargs): ...
     def repeat(self, repeats, axis=...): ...
-    @final
-    def where(self, cond, other=None) -> None: ...
-    def drop(self, codes, level=None, errors: str = "raise") -> Self: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
+    def drop(self, codes, level: Level | None = None, errors: str = "raise") -> Self: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
     def swaplevel(self, i: int = -2, j: int = -1): ...
     def reorder_levels(self, order): ...
     def sortlevel(
         self,
         level: Level | Sequence[Level] = 0,
         ascending: bool = True,
-        sort_remaining: bool = ...,
+        sort_remaining: bool = True,
         na_position: NaPosition = "first",
     ): ...
     @final
@@ -162,20 +152,15 @@ class MultiIndex(Index):
     def get_slice_bound(
         self, label: Hashable | Sequence[Hashable], side: str
     ) -> int: ...
-    def get_loc_level(self, key, level=..., drop_level: bool = True): ...
+    def get_loc_level(
+        self, key, level: Level | list[Level] | None = None, drop_level: bool = True
+    ): ...
     def get_locs(self, seq): ...
-    def truncate(self, before=None, after=None): ...
+    def truncate(
+        self, before: IndexLabel | None = None, after: IndexLabel | None = None
+    ): ...
     def equals(self, other) -> bool: ...
     def equal_levels(self, other): ...
-    @final
-    def union(self, other, sort=None): ...  # pyrefly: ignore
-    @final
-    def intersection(  # pyright: ignore[reportIncompatibleMethodOverride]
-        self, other: list | Self, sort: bool | None = False
-    ): ...
-    @final
-    def difference(self, other, sort=None): ...
-    def astype(self, dtype: DtypeArg, copy: bool = True) -> Self: ...
     def insert(self, loc, item): ...
     def delete(self, loc): ...
     def isin(self, values, level=...) -> np_ndarray_bool: ...

pandas-stubs/core/indexes/period.pyi

@@ -57,7 +57,6 @@ class PeriodIndex(DatetimeIndexOpsMixin[pd.Period], PeriodIndexFieldOps):
     @final
     def __array_wrap__(self, result, context=...): ...
     def asof_locs(self, where, mask): ...
-    def astype(self, dtype, copy: bool = True): ...
     def searchsorted(self, value, side: str = ..., sorter=...): ...
     @property
     def is_full(self) -> bool: ...
@@ -77,9 +76,6 @@ class PeriodIndex(DatetimeIndexOpsMixin[pd.Period], PeriodIndexFieldOps):
         return_indexers: bool = ...,
         sort: bool = ...,
     ): ...
-    @final
-    def difference(self, other, sort=None): ...
-    def memory_usage(self, deep: bool = False): ...
     @property
     def freqstr(self) -> str: ...
     def shift(self, periods: int = 1, freq=...) -> Self: ...

pandas-stubs/core/indexes/range.pyi

@@ -53,7 +53,6 @@ class RangeIndex(Index[int]):
     @final
     def get_indexer(self, target, method=..., limit=..., tolerance=...): ...
     def tolist(self): ...
-    def copy(self, name: Hashable = ..., deep: bool = False, dtype=..., **kwargs): ...
     def min(self, axis=..., skipna: bool = ..., *args, **kwargs): ...
     def max(self, axis=..., skipna: bool = ..., *args, **kwargs): ...
     def argsort(self, *args, **kwargs): ...
@@ -79,7 +78,7 @@ class RangeIndex(Index[int]):
     def any(self) -> bool: ...
     @final
     def union(  # pyrefly: ignore
-        self, other: list[HashableT] | Index, sort=None
+        self, other: list[HashableT] | Index, sort: bool | None = None
     ) -> Index | Index[int] | RangeIndex: ...
     @overload  # type: ignore[override]
     def __getitem__(

pandas-stubs/core/indexes/timedeltas.pyi

@@ -70,7 +70,6 @@ class TimedeltaIndex(DatetimeTimedeltaMixin[Timedelta], TimedeltaIndexProperties
         self, other: dt.timedelta | Sequence[dt.timedelta]
     ) -> Index[int]: ...
     def __rfloordiv__(self, other: dt.timedelta | Sequence[dt.timedelta]) -> Index[int]: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
-    def astype(self, dtype, copy: bool = True): ...
     def searchsorted(self, value, side: str = ..., sorter=...): ...
     @property
     def inferred_type(self) -> str: ...
@@ -82,7 +81,7 @@ def timedelta_range(
     start: TimedeltaConvertibleTypes | None = None,
     end: TimedeltaConvertibleTypes | None = None,
     periods: int | None = None,
-    freq: str | DateOffset | Timedelta | dt.timedelta | None = "D",
+    freq: str | DateOffset | Timedelta | dt.timedelta | None = None,
     name: Hashable | None = None,
     closed: Literal["left", "right"] | None = None,
     *,