TYP: Fix return type of Series.keys() fro list to Index (#1101) #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported Index from pandas and Changed keys method: def keys(self) -> Index: ...
Dr-Irv
requested changes
Feb 6, 2025
Add a test for issue # 1101
Dr-Irv
requested changes
Feb 7, 2025
Following the pandas pattern. Co-authored-by: Irv Lustig <[email protected]>
|
Thank you for your feedback. It's my very first issue and pull request. |
Dr-Irv
requested changes
Feb 7, 2025
There was a problem hiding this comment.
You need to set up the pre-commit so things are properly formatted. See the output here:
https://github.com/pandas-dev/pandas-stubs/actions/runs/13202706637/job/36858930373?pr=1106
And instructions here for setting up your local testing environment:
https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md
Dr-Irv
requested changes
Feb 10, 2025
|
@Dr-Irv, thank you for your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.