Skip to content

type dataframe.combine #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

type dataframe.combine #1142

merged 1 commit into from
Mar 3, 2025

Conversation

MarcoGorelli
Copy link
Member

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Mar 3, 2025

@MarcoGorelli this looks good to me. Change to draft when you want me to approve/merge

@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 3, 2025 16:55
@MarcoGorelli
Copy link
Member Author

thanks! sorry i probably forgot to undraft

Dr-Irv
Dr-Irv approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MarcoGorelli

@Dr-Irv Dr-Irv merged commit cf79529 into pandas-dev:main Mar 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcoGorelli @Dr-Irv