GH1052 python 3.13 support #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure why it fails on windows-latest, will dig into it. Otherwise looks clean on other setups so encouraging! |
Dr-Irv
requested changes
Mar 3, 2025
pyproject.toml
Outdated
Comment on lines
52
to
53
| # for tables, Windows build fails on 3.10.1 | ||
| tables = { version = ">=3.10.1", python = "<4" } # 3.8.0 depends on blosc2 which caps python to <4 |
There was a problem hiding this comment.
remove the comment and make it >= 3.10.2 since that is what worked for Windows with 3.13 anyway and 3.10.2 is needed with python 3.13.
There was a problem hiding this comment.
That would require Python3.11 at minimum so will leave it floating from 3.10.1.
…tubs into gh1052_python313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value