Skip to content

Conversation

loicdiridollou
Copy link
Member

@loicdiridollou
Copy link
Member Author

Please review #1185 first due to fixes for new pyright version.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are locking pyright, don't want to change the part of pyproject.toml that was problematic.

pyproject.toml Outdated
reportUnknownVariableType = false
reportUnusedVariable = false
reportPrivateUsage = false
reportPrivateImportUsage = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit 8434bde into pandas-dev:main Apr 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update precommit to align with latest versions of ruff/black/isort/codesplee

2 participants