Improve var and class names

Author: PedroM4rques

pandas/__init__.py

@@ -347,7 +347,7 @@
     "wide_to_long",
 ]
 
-from pandas.core.accessor import DataFrameAccessorLoader
+from .core.accessor import AccessorEntryPointLoader
 
-DataFrameAccessorLoader.load()
-del DataFrameAccessorLoader
+AccessorEntryPointLoader.load()
+del AccessorEntryPointLoader

pandas/core/accessor.py

@@ -398,31 +398,31 @@ def register_index_accessor(name: str) -> Callable[[TypeT], TypeT]:
     return _register_accessor(name, Index)
 
 
-class DataFrameAccessorLoader:
-    """Loader class for registering DataFrame accessors via entry points."""
+class AccessorEntryPointLoader:  # is this a good name for the class?
+    """Loader class for registering accessors via entry points."""
 
-    ENTRY_POINT_GROUP: str = "pandas_dataframe_accessor"
+    ENTRY_POINT_GROUP: str = "pandas_accessor"
 
     @classmethod
     def load(cls) -> None:
-        """loads and registers accessors defined by 'pandas_dataframe_accessor'."""
-        eps = entry_points(group=cls.ENTRY_POINT_GROUP)
-        names: set[str] = set()
+        """loads and registers accessors defined by 'pandas_accessor'."""
+        packages = entry_points(group=cls.ENTRY_POINT_GROUP)
+        unique_packages_names: set[str] = set()
 
-        for ep in eps:
-            name: str = ep.name
-
-            if name in names:  # Verifies duplicated package names
+        for package in packages:
+            # Verifies duplicated package names
+            if package.name in unique_packages_names:
                 warnings.warn(
-                    f"Warning: you have two packages with the same name: '{name}'. "
+                    "Warning: you have two packages with the same name:"
+                    f" '{package.name}'\n"
                     "Uninstall the package you don't want to use "
                     "in order to remove this warning.\n",
                     UserWarning,
                     stacklevel=2,
                 )
 
             else:
-                names.add(name)
+                unique_packages_names.add(package.name)
 
             def make_property(ep):
                 def accessor(self) -> Any:
@@ -431,4 +431,4 @@ def accessor(self) -> Any:
 
                 return accessor
 
-            register_dataframe_accessor(name)(make_property(ep))
+            register_dataframe_accessor(package.name)(make_property(package))

pandas/tests/test_plugis_entrypoint_loader.py

@@ -1,6 +1,6 @@
 import pandas as pd
 import pandas._testing as tm
-from pandas.core.accessor import DataFrameAccessorLoader
+from pandas.core.accessor import AccessorEntryPointLoader
 
 
 def test_no_accessors(monkeypatch):
@@ -13,7 +13,7 @@ def mock_entry_points(*, group):
     # Patch entry_points in the correct module
     monkeypatch.setattr("pandas.core.accessor.entry_points", mock_entry_points)
 
-    DataFrameAccessorLoader.load()
+    AccessorEntryPointLoader.load()
 
 
 def test_load_dataframe_accessors(monkeypatch):
@@ -34,14 +34,14 @@ def test_method(self):
 
     # Mock entry_points
     def mock_entry_points(*, group):
-        if group == DataFrameAccessorLoader.ENTRY_POINT_GROUP:
+        if group == AccessorEntryPointLoader.ENTRY_POINT_GROUP:
             return [MockEntryPoint()]
         return []
 
     # Patch entry_points in the correct module
     monkeypatch.setattr("pandas.core.accessor.entry_points", mock_entry_points)
 
-    DataFrameAccessorLoader.load()
+    AccessorEntryPointLoader.load()
 
     # Create DataFrame and verify that the accessor was registered
     df = pd.DataFrame({"a": [1, 2, 3]})
@@ -80,18 +80,18 @@ def which(self):
             return Accessor2
 
     def mock_entry_points(*, group):
-        if group == DataFrameAccessorLoader.ENTRY_POINT_GROUP:
+        if group == AccessorEntryPointLoader.ENTRY_POINT_GROUP:
             return [MockEntryPoint1(), MockEntryPoint2()]
         return []
 
     monkeypatch.setattr("pandas.core.accessor.entry_points", mock_entry_points)
 
     # Check that the UserWarning is raised
     with tm.assert_produces_warning(UserWarning, match="duplicate_accessor") as record:
-        DataFrameAccessorLoader.load()
+        AccessorEntryPointLoader.load()
 
     messages = [str(w.message) for w in record]
-    assert any("two packages with the same name" in msg for msg in messages)
+    assert any("you have two packages with the same name:" in msg for msg in messages)
 
     df = pd.DataFrame({"x": [1, 2, 3]})
     assert hasattr(df, "duplicate_accessor")
@@ -129,15 +129,15 @@ def which(self):
             return Accessor2
 
     def mock_entry_points(*, group):
-        if group == DataFrameAccessorLoader.ENTRY_POINT_GROUP:
+        if group == AccessorEntryPointLoader.ENTRY_POINT_GROUP:
             return [MockEntryPoint1(), MockEntryPoint2()]
         return []
 
     monkeypatch.setattr("pandas.core.accessor.entry_points", mock_entry_points)
 
     # Check that no UserWarning is raised
     with tm.assert_produces_warning(None, check_stacklevel=False):
-        DataFrameAccessorLoader.load()
+        AccessorEntryPointLoader.load()
 
     df = pd.DataFrame({"x": [1, 2, 3]})
     assert hasattr(df, "accessor1"), "Accessor1 not registered"
@@ -191,15 +191,15 @@ def which(self):
             return Accessor3
 
     def mock_entry_points(*, group):
-        if group == DataFrameAccessorLoader.ENTRY_POINT_GROUP:
+        if group == AccessorEntryPointLoader.ENTRY_POINT_GROUP:
             return [MockEntryPoint1(), MockEntryPoint2(), MockEntryPoint3()]
         return []
 
     monkeypatch.setattr("pandas.core.accessor.entry_points", mock_entry_points)
 
     # Capture warnings
     with tm.assert_produces_warning(UserWarning, match="duplicate_accessor") as record:
-        DataFrameAccessorLoader.load()
+        AccessorEntryPointLoader.load()
 
     messages = [str(w.message) for w in record]