Skip to content

Commit 091baa8

Browse files
String dtype: use ObjectEngine for indexing for now correctness over performance
1 parent ee3c18f commit 091baa8

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

pandas/core/indexes/base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -875,8 +875,7 @@ def _engine(
875875
# error: Item "ExtensionArray" of "Union[ExtensionArray,
876876
# ndarray[Any, Any]]" has no attribute "_ndarray" [union-attr]
877877
target_values = self._data._ndarray # type: ignore[union-attr]
878-
elif is_string_dtype(self.dtype) and not is_object_dtype(self.dtype):
879-
return libindex.StringEngine(target_values)
878+
# TODO re-enable StringEngine for string dtype
880879

881880
# error: Argument 1 to "ExtensionEngine" has incompatible type
882881
# "ndarray[Any, Any]"; expected "ExtensionArray"

0 commit comments

Comments
 (0)