added TypeError if object dtypes are dtected in dataframe

Author: sharkipelago

doc/source/whatsnew/v3.0.0.rst

@@ -73,6 +73,7 @@ Other enhancements
 - :meth:`.DataFrameGroupBy.transform`, :meth:`.SeriesGroupBy.transform`, :meth:`.DataFrameGroupBy.agg`, :meth:`.SeriesGroupBy.agg`, :meth:`.SeriesGroupBy.apply`, :meth:`.DataFrameGroupBy.apply` now support ``kurt`` (:issue:`40139`)
 - :meth:`DataFrame.apply` supports using third-party execution engines like the Bodo.ai JIT compiler (:issue:`60668`)
 - :meth:`DataFrame.iloc` and :meth:`Series.iloc` now support boolean masks in ``__getitem__`` for more consistent indexing behavior (:issue:`60994`)
+- :meth:`DataFrame.round` now raises a ``Type Error`` if any columns are non-numeric (:issue:`61679`)
 - :meth:`DataFrameGroupBy.transform`, :meth:`SeriesGroupBy.transform`, :meth:`DataFrameGroupBy.agg`, :meth:`SeriesGroupBy.agg`, :meth:`RollingGroupby.apply`, :meth:`ExpandingGroupby.apply`, :meth:`Rolling.apply`, :meth:`Expanding.apply`, :meth:`DataFrame.apply` with ``engine="numba"`` now supports positional arguments passed as kwargs (:issue:`58995`)
 - :meth:`Rolling.agg`, :meth:`Expanding.agg` and :meth:`ExponentialMovingWindow.agg` now accept :class:`NamedAgg` aggregations through ``**kwargs`` (:issue:`28333`)
 - :meth:`Series.map` can now accept kwargs to pass on to func (:issue:`59814`)

pandas/core/frame.py

@@ -11152,7 +11152,7 @@ def round(
         Returns
         -------
         DataFrame
-            A DataFrame with the affected columns rounded to the specified
+            A DataFrame with columns rounded to the specified
             number of decimal places.
 
         See Also
@@ -11227,7 +11227,10 @@ def _series_round(ser: Series, decimals: int) -> Series:
             return ser
 
         nv.validate_round(args, kwargs)
-
+        if "object" in self.dtypes.values:
+            raise TypeError(
+                "All columns must be numeric dtype, but got object dtype column(s)"
+            )
         if isinstance(decimals, (dict, Series)):
             if isinstance(decimals, Series) and not decimals.index.is_unique:
                 raise ValueError("Index of decimals must be unique")

pandas/tests/frame/methods/test_round.py

@@ -5,7 +5,6 @@
 from pandas import (
     DataFrame,
     Series,
-    date_range,
 )
 import pandas._testing as tm
 
@@ -143,29 +142,6 @@ def test_round_numpy_with_nan(self):
         expected = Series([2.0, np.nan, 0.0]).to_frame()
         tm.assert_frame_equal(result, expected)
 
-    def test_round_mixed_type(self):
-        # GH#11885
-        df = DataFrame(
-            {
-                "col1": [1.1, 2.2, 3.3, 4.4],
-                "col2": ["1", "a", "c", "f"],
-                "col3": date_range("20111111", periods=4),
-            }
-        )
-        round_0 = DataFrame(
-            {
-                "col1": [1.0, 2.0, 3.0, 4.0],
-                "col2": ["1", "a", "c", "f"],
-                "col3": date_range("20111111", periods=4),
-            }
-        )
-        tm.assert_frame_equal(df.round(), round_0)
-        tm.assert_frame_equal(df.round(1), df)
-        tm.assert_frame_equal(df.round({"col1": 1}), df)
-        tm.assert_frame_equal(df.round({"col1": 0}), round_0)
-        tm.assert_frame_equal(df.round({"col1": 0, "col2": 1}), round_0)
-        tm.assert_frame_equal(df.round({"col3": 1}), df)
-
     def test_round_with_duplicate_columns(self):
         # GH#11611
 
@@ -223,3 +199,15 @@ def test_round_empty_not_input(self):
         result = df.round()
         tm.assert_frame_equal(df, result)
         assert df is not result
+
+    def test_round_non_numeric_columns(self):
+        # GH#61679
+        df = DataFrame(
+            {
+                "a": [1.2234242333234, 323432.3243423, np.nan],
+                "b": ["a", "b", "c"],
+            }
+        )
+        msg = "All columns must be numeric dtype, but got object dtype column\\(s\\)"
+        with pytest.raises(TypeError, match=msg):
+            df.round()